Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2088613002: Move c/b/crash_upload_list* to subdir with OWNERS (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@crash-list-all
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move c/b/crash_upload_list* to subdir with OWNERS By request in https://crrev.com/2070993002, follows that CL. R=thestig@chromium.org BUG=620762 Committed: https://crrev.com/389bcb40c53660a423ab7e5ff008edcfae24bfc6 Cr-Commit-Position: refs/heads/master@{#401040}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -185 lines) Patch
D chrome/browser/crash_upload_list.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/crash_upload_list.cc View 1 chunk +0 lines, -31 lines 0 comments Download
A chrome/browser/crash_upload_list/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/crash_upload_list/crash_upload_list.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/crash_upload_list/crash_upload_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/crash_upload_list/crash_upload_list_crashpad.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/crash_upload_list_crashpad.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/crash_upload_list_crashpad.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
scottmg
4 years, 6 months ago (2016-06-20 23:14:16 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/2088613002/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/2088613002/diff/1/chrome/chrome_browser.gypi#newcode654 chrome/chrome_browser.gypi:654: 'browser/tracing/chrome_tracing_delegate.h', sorting is hard
4 years, 6 months ago (2016-06-21 07:24:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088613002/1
4 years, 6 months ago (2016-06-21 16:31:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/204168)
4 years, 6 months ago (2016-06-21 16:36:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088613002/20001
4 years, 6 months ago (2016-06-21 17:03:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 17:57:47 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 18:16:30 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/389bcb40c53660a423ab7e5ff008edcfae24bfc6
Cr-Commit-Position: refs/heads/master@{#401040}

Powered by Google App Engine
This is Rietveld 408576698