Implement RenderPass StructTraits

cc/ipc/render_pass_struct_traits.cc

Index: cc/ipc/render_pass_struct_traits.cc
diff --git a/cc/ipc/render_pass_struct_traits.cc b/cc/ipc/render_pass_struct_traits.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ec2efde8e98cd2ef83bd5ac7961600ee69bfe5a4
--- /dev/null
+++ b/cc/ipc/render_pass_struct_traits.cc
@@ -0,0 +1,72 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cc/ipc/render_pass_struct_traits.h"
+#include "cc/ipc/shared_quad_state_struct_traits.h"
+
+namespace mojo {
+
+// static
+void* StructTraits<cc::mojom::RenderPass, std::unique_ptr<cc::RenderPass>>::
+    SetUpContext(const std::unique_ptr<cc::RenderPass>& input) {
+  DCHECK_GT(input->quad_list.size(), 0u);
+  mojo::Array<uint32_t>* sqs_references =
+      new mojo::Array<uint32_t>(input->quad_list.size());
+  cc::SharedQuadStateList::ConstIterator sqs_iter =
+      input->shared_quad_state_list.begin();
+  for (auto it = input->quad_list.begin(); it != input->quad_list.end(); ++it) {
+    if ((*it)->shared_quad_state != *sqs_iter)
+      ++sqs_iter;
+    (*sqs_references)[it.index()] = sqs_iter.index();
+    DCHECK_EQ(*sqs_iter, (*it)->shared_quad_state);
+  }
+  DCHECK_EQ(input->shared_quad_state_list.size() - 1, sqs_iter.index());
+  return sqs_references;
+}
+
+// static
+void StructTraits<cc::mojom::RenderPass, std::unique_ptr<cc::RenderPass>>::
+    TearDownContext(const std::unique_ptr<cc::RenderPass>& input,
+                    void* context) {
+  // static_cast to ensure the destructor is called.
+  delete static_cast<mojo::Array<uint32_t>*>(context);
+}
+
+// static
+bool StructTraits<cc::mojom::RenderPass, std::unique_ptr<cc::RenderPass>>::Read(

[danakj, 2016/06/22 00:05:09]

Where does the writer live?

[Fady Samuel, 2016/06/22 20:08:14]

All the accessors in render_pass_struct_traits.h. A StructTraits tells mojo how
to read a C++ type to translate it into the wire format.

+    cc::mojom::RenderPassDataView data,
+    std::unique_ptr<cc::RenderPass>* out) {
+  *out = cc::RenderPass::Create();
+  if (!data.ReadId(&(*out)->id) || !data.ReadOutputRect(&(*out)->output_rect) ||
+      !data.ReadDamageRect(&(*out)->damage_rect) ||
+      !data.ReadTransformToRootTarget(&(*out)->transform_to_root_target)) {
+    return false;
+  }
+  (*out)->has_transparent_background = data.has_transparent_background();
+  if (!data.ReadQuadList(&(*out)->quad_list) ||
+      !data.ReadSharedQuadStateList(&(*out)->shared_quad_state_list))
+    return false;
+
+  mojo::Array<uint32_t> shared_quad_state_references;
+  if (!data.ReadSharedQuadStateReferences(&shared_quad_state_references))
+    return false;
+
+  if ((*out)->quad_list.size() != shared_quad_state_references.size())
+    return false;
+
+  cc::SharedQuadStateList::ConstIterator sqs_iter =
+      (*out)->shared_quad_state_list.begin();
+  for (auto it = (*out)->quad_list.begin(); it != (*out)->quad_list.end();
+       ++it) {
+    if (sqs_iter.index() != shared_quad_state_references[it.index()])
+      ++sqs_iter;
+    DCHECK_EQ(shared_quad_state_references[it.index()], sqs_iter.index());

[yzshen1, 2016/06/21 23:51:21]

(I am not familiar with this data structure...)
Are these DCHECKs never violated even if the message sender is malicious and
sends us invalid data?

[danakj, 2016/06/22 00:05:09]

1On 2016/06/21 23:51:21, yzshen1 wrote:
The receiver needs to reject bad messages. The sender should DCHECK to find bugs
there.

[Fady Samuel, 2016/06/22 20:08:14]

Done.

[Fady Samuel, 2016/06/22 20:08:14]

Good point. I changed them to return false if the conditions are violated.

+    (*it)->shared_quad_state = *sqs_iter;
+    DCHECK_NE(nullptr, (*it)->shared_quad_state);
+  }
+  DCHECK_EQ((*out)->shared_quad_state_list.size() - 1, sqs_iter.index());
+  return true;
+}
+
+}  // namespace mojo