Implement RenderPass StructTraits

cc/ipc/quads_struct_traits.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/ipc/quads_struct_traits.h"
 
 namespace mojo {
 
 namespace {
 
@@ skipping 128 matching lines @@
   return true;
 }
 
 // static
 bool StructTraits<cc::mojom::RenderPassQuadState, cc::DrawQuad>::Read(
     cc::mojom::RenderPassQuadStateDataView data,
     cc::DrawQuad* out) {
   cc::RenderPassDrawQuad* quad = static_cast<cc::RenderPassDrawQuad*>(out);
   quad->resources.ids[cc::RenderPassDrawQuad::kMaskResourceIdIndex] =
       data.mask_resource_id();
+  quad->resources.count = data.mask_resource_id() ? 1 : 0;
   return data.ReadRenderPassId(&quad->render_pass_id) &&
          data.ReadMaskUvScale(&quad->mask_uv_scale) &&
          data.ReadMaskTextureSize(&quad->mask_texture_size) &&
          data.ReadFilters(&quad->filters) &&
          data.ReadFiltersScale(&quad->filters_scale) &&
          data.ReadBackgroundFilters(&quad->background_filters);
 }
 
 // static
 bool StructTraits<cc::mojom::SolidColorQuadState, cc::DrawQuad>::Read(
@@ skipping 13 matching lines @@
   return data.ReadSurface(&quad->surface_id);
 }
 
 // static
 bool StructTraits<cc::mojom::TextureQuadState, cc::DrawQuad>::Read(
     cc::mojom::TextureQuadStateDataView data,
     cc::DrawQuad* out) {
   cc::TextureDrawQuad* quad = static_cast<cc::TextureDrawQuad*>(out);
   quad->resources.ids[cc::TextureDrawQuad::kResourceIdIndex] =
       data.resource_id();
+  quad->resources.count = 1;
   quad->premultiplied_alpha = data.premultiplied_alpha();
   if (!data.ReadUvTopLeft(&quad->uv_top_left) ||
       !data.ReadUvBottomRight(&quad->uv_bottom_right)) {
     return false;
   }
   quad->background_color = data.background_color();
   CArray<float> vertex_opacity_array = {4, 4, &quad->vertex_opacity[0]};
   if (!data.ReadVertexOpacity(&vertex_opacity_array))
     return false;
 
   quad->y_flipped = data.y_flipped();
   quad->nearest_neighbor = data.nearest_neighbor();
   quad->secure_output_only = data.secure_output_only();
   return true;
 }
 
 // static
 bool StructTraits<cc::mojom::TileQuadState, cc::DrawQuad>::Read(
     cc::mojom::TileQuadStateDataView data,
     cc::DrawQuad* out) {
   cc::TileDrawQuad* quad = static_cast<cc::TileDrawQuad*>(out);
   if (!data.ReadTexCoordRect(&quad->tex_coord_rect) ||
       !data.ReadTextureSize(&quad->texture_size)) {
     return false;
   }
 
   quad->swizzle_contents = data.swizzle_contents();
   quad->nearest_neighbor = data.nearest_neighbor();
   quad->resources.ids[cc::TileDrawQuad::kResourceIdIndex] = data.resource_id();
+  quad->resources.count = 1;
   return true;
 }
 
 cc::mojom::YUVColorSpace
 EnumTraits<cc::mojom::YUVColorSpace, cc::YUVVideoDrawQuad::ColorSpace>::ToMojom(
     cc::YUVVideoDrawQuad::ColorSpace color_space) {
   switch (color_space) {
     case cc::YUVVideoDrawQuad::REC_601:
       return cc::mojom::YUVColorSpace::REC_601;
     case cc::YUVVideoDrawQuad::REC_709:
@@ skipping 35 matching lines @@
     return false;
   }
   quad->resources.ids[cc::YUVVideoDrawQuad::kYPlaneResourceIdIndex] =
       data.y_plane_resource_id();
   quad->resources.ids[cc::YUVVideoDrawQuad::kUPlaneResourceIdIndex] =
       data.u_plane_resource_id();
   quad->resources.ids[cc::YUVVideoDrawQuad::kVPlaneResourceIdIndex] =
       data.v_plane_resource_id();
   quad->resources.ids[cc::YUVVideoDrawQuad::kAPlaneResourceIdIndex] =
       data.a_plane_resource_id();
+  quad->resources.count = data.a_plane_resource_id() ? 4 : 3;

[danakj, 2016/06/22 20:51:35]

This depends on the A resource coming last in the array, since you insert them
based on the A index, not just in order that they are written. Maybe you can
static assert this here so we know it's the case in the future?

[Fady Samuel, 2016/06/22 21:41:19]

Done.

+
   if (!data.ReadColorSpace(&quad->color_space))
     return false;
   quad->resource_offset = data.resource_offset();
   quad->resource_multiplier = data.resource_multiplier();
   return true;
 }
 
 // static
 bool StructTraits<cc::mojom::DrawQuad, cc::DrawQuad>::Read(
     cc::mojom::DrawQuadDataView data,
@@ skipping 70 matching lines @@
     if (!AllocateAndConstruct(materials[i], out))
       return false;
   }
   // The materials array and the quads array are expected to be the same size.
   // If they are not, then deserialization will fail.
   QuadListArray quad_list_array = {materials.size(), out};
   return data.ReadQuads(&quad_list_array);
 }
 
 }  // namespace mojo