cc/ipc/render_pass.mojom - Issue 2088603002: Implement RenderPass StructTraits

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/ipc/render_pass.mojom

Issue 2088603002: Implement RenderPass StructTraits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary change Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« cc/ipc/quads_struct_traits.cc ('K') | « cc/ipc/quads_struct_traits.cc ('k') | cc/ipc/render_pass.typemap » ('j') | cc/ipc/render_pass_struct_traits.cc » ('J')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module cc.mojom;	5 module cc.mojom;

6	6

7 import "cc/ipc/render_pass_id.mojom";	7 import "cc/ipc/render_pass_id.mojom";

8 import "cc/ipc/quads.mojom";	8 import "cc/ipc/quads.mojom";

9 import "cc/ipc/shared_quad_state.mojom";	9 import "cc/ipc/shared_quad_state.mojom";

10 import "ui/gfx/geometry/mojo/geometry.mojom";	10 import "ui/gfx/geometry/mojo/geometry.mojom";

11 import "ui/gfx/mojo/transform.mojom";	11 import "ui/gfx/mojo/transform.mojom";

12	12

13 // See cc/quads/render_pass.h.	13 // See cc/quads/render_pass.h.

14 struct RenderPass {	14 struct RenderPass {

15 cc.mojom.RenderPassId id;	15 RenderPassId id;
	danakj 2016/06/22 00:05:09 Can you explain this to me? Can you explain this to me? Fady Samuel 2016/06/22 20:08:14 Explain what? We're in the cc.mojom module and so Show quoted text On 2016/06/22 00:05:09, danakj wrote: > Can you explain this to me? Explain what? We're in the cc.mojom module and so we don't need the cc.mojom prefix. danakj 2016/06/22 20:51:34 So it's equivalent. ok Thanks Show quoted text On 2016/06/22 20:08:14, Fady Samuel wrote: > On 2016/06/22 00:05:09, danakj wrote: > > Can you explain this to me? > > Explain what? We're in the cc.mojom module and so we don't need the cc.mojom > prefix. So it's equivalent. ok Thanks
16 gfx.mojom.Rect output_rect;	16 gfx.mojom.Rect output_rect;

17 gfx.mojom.Rect damage_rect;	17 gfx.mojom.Rect damage_rect;

18 gfx.mojom.Transform transform_to_root_target;	18 gfx.mojom.Transform transform_to_root_target;

19 bool has_transparent_background;	19 bool has_transparent_background;

20 array<DrawQuad> quads;	20 QuadList quad_list;

21 cc.mojom.SharedQuadStateList shared_quad_states;	21 array<uint32> shared_quad_state_references;

	22 SharedQuadStateList shared_quad_state_list;

22 };	23 };

OLD	NEW