[Findit] pass compile_targets using build_parameter(recipe side change).

scripts/slave/recipes/findit/chromium/compile.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 
 from recipe_engine.config import List
 from recipe_engine.config import Single
 from recipe_engine.recipe_api import Property
 
 
 DEPS = [
+    'buildbucket',
     'chromium',
     'chromium_tests',
     'findit',
     'depot_tools/gclient',
     'recipe_engine/json',
     'recipe_engine/path',
     'recipe_engine/platform',
     'recipe_engine/properties',
     'recipe_engine/python',
     'recipe_engine/raw_io',
     'recipe_engine/step',
 ]
 
 
 PROPERTIES = {
     'target_mastername': Property(
         kind=str, help='The target master to match compile config to.'),
     'target_buildername': Property(
         kind=str, help='The target builder to match compile config to.'),
     'good_revision': Property(
         kind=str, help='The last known good chromium revision.'),
     'bad_revision': Property(
         kind=str, help='The first known bad chromium revision.'),
     'compile_targets': Property(
         kind=List(basestring), default=None,
         help='The failed compile targets, eg: browser_tests, '
              'obj/path/to/source.o, gen/path/to/generated.cc, etc.'),
+    'buildbucket': Property(
+        default=None,
+        help='The buildbucket property in which we can find build id. '
+             'We need to use build id to get compile_targets.'),
     'use_analyze': Property(
         kind=Single(bool, empty_val=False, required=False), default=True,
         help='Use analyze to filter out affected targets.'),
     'suspected_revisions': Property(
         kind=List(basestring), default=[],
         help='A list of suspected revisions from heuristic analysis.'),
     'use_bisect': Property(
         kind=Single(bool, empty_val=False, required=False), default=True,
         help='Use bisect to skip more revisions. '
              'Effective only when compile_targets is given.'),
@@ skipping 58 matching lines @@
           mb_buildername=target_buildername,
           override_bot_type='builder_tester')
       return CompileResult.PASSED
     except api.step.InfraFailure:
       raise
     except api.step.StepFailure:
       return CompileResult.FAILED
 
 
 def RunSteps(api, target_mastername, target_buildername,
-             good_revision, bad_revision,
-             compile_targets, use_analyze, suspected_revisions, use_bisect):
+             good_revision, bad_revision, compile_targets,
+             buildbucket, use_analyze, suspected_revisions, use_bisect):
+  if not compile_targets:
+    # compile_targets should be saved in build parameter in this case.

[stgao, 2016/06/21 05:43:16]

nit: It might not be set though if no ninja output nodes are extracted.

[chanli, 2016/06/21 21:51:19]

Done.

+    buildbucket_json = json.loads(buildbucket)
+    build_id = buildbucket_json['build']['id']
+    get_build_result = api.buildbucket.get_build(build_id)
+    compile_targets = json.loads(
+        get_build_result.stdout['build']['parameters_json']).get(
+            'additional_build_parameters', {}).get('compile_targets')
+
   bot_config = api.chromium_tests.create_bot_config_object(
       target_mastername, target_buildername)
   api.chromium_tests.configure_build(
       bot_config, override_bot_type='builder_tester')
 
   # Sync to bad revision, and retrieve revisions in the regression range.
   api.chromium_tests.prepare_checkout(
       bot_config,
       root_solution_revision=bad_revision)
 
@@ skipping 157 matching lines @@
     # Set the report as a build property too, so that it will be reported back
     # to Buildbucket and Findit will pull from there instead of buildbot master.
     step_result.presentation.properties['report'] = report
 
   return report
 
 
 def GenTests(api):
   def props(compile_targets=None, use_analyze=False,
             good_revision=None, bad_revision=None,
-            suspected_revisions=None, use_bisect=False):
+            suspected_revisions=None, use_bisect=False, buildbucket=None):
     properties = {
         'mastername': 'tryserver.chromium.linux',
         'buildername': 'linux_variable',
         'slavename': 'build1-a1',
         'buildnumber': '1',
         'target_mastername': 'chromium.linux',
         'target_buildername': 'Linux Builder',
         'good_revision': good_revision or 'r0',
         'bad_revision': bad_revision or 'r1',
         'use_analyze': use_analyze,
         'use_bisect': use_bisect,
     }
     if compile_targets:
       properties['compile_targets'] = compile_targets
     if suspected_revisions:
       properties['suspected_revisions'] = suspected_revisions
+    if buildbucket:
+      properties['buildbucket'] = buildbucket
     return api.properties(**properties) + api.platform.name('linux')
 
+  def simulated_buildbucket_output(additional_build_parameters):
+    buildbucket_output = {
+        'build':{
+          'parameters_json': json.dumps(additional_build_parameters)
+        }
+    }
+
+    return api.buildbucket.step_data(
+        'buildbucket.get',
+        stdout=api.raw_io.output(json.dumps(buildbucket_output)))
+
   yield (
       api.test('compile_specified_targets') +
       props(compile_targets=['target_name']) +
       api.override_step_data('test r1.check_targets',
                              api.json.output({
                                  'found': ['target_name'],
                                  'not_found': [],
                              }))
   )
 
   yield (
+      api.test('compile_specified_targets_from_parameter') +
+      props(buildbucket=json.dumps({'build': {'id': 'id1'}})) +
+      simulated_buildbucket_output({
+          'additional_build_parameters': {
+              'compile_targets': ['target_name']
+      }}) +
+      api.override_step_data('test r1.check_targets',
+                             api.json.output({
+                                 'found': ['target_name'],
+                                 'not_found': [],
+                             }))
+  )
+
+  yield (
       api.test('compile_none_existing_targets') +
       props(compile_targets=['gen/a/b/source.cc']) +
       api.override_step_data('test r1.check_targets',
                              api.json.output({
                                  'found': [],
                                  'not_found': ['gen/a/b/source.cc'],
                              }))
   )
 
 
   yield (
       api.test('compile_default_targets') +
-      props() +
+      props(buildbucket=json.dumps({'build': {'id': 'id1'}})) +
+      simulated_buildbucket_output({
+          'additional_build_parameters': {
+              'compile_targets': None
+      }}) +
       api.override_step_data('test r1.read test spec',
                              api.json.output({
                                  'Linux Builder': {
                                      'additional_compile_targets': [
                                          'base_unittests',
                                      ],
                                  }
                              }))
   )
 
   yield (
       api.test('compile_succeeded') +
-      props() +
+      props(buildbucket=json.dumps({'build': {'id': 'id1'}})) +
+      simulated_buildbucket_output({}) +
       api.override_step_data('test r1.compile', retcode=0)
   )
 
   yield (
       api.test('compile_failed') +
-      props() +
+      props(buildbucket=json.dumps({'build': {'id': 'id1'}})) +
+      simulated_buildbucket_output({}) +
       api.override_step_data('test r1.compile', retcode=1)
   )
 
   yield (
       api.test('failed_compile_upon_infra_failure_goma_setup_failure') +
       props(compile_targets=['target_name']) +
       api.override_step_data('test r1.check_targets',
                              api.json.output({
                                  'found': ['target_name'],
                                  'not_found': [],
@@ skipping 50 matching lines @@
                           'num_user_error': 1,
                       },
                   },
               ],
           }),
           retcode=1)
   )
 
   yield (
       api.test('compile_skipped') +
-      props(use_analyze=True) +
+      props(use_analyze=True,
+            buildbucket=json.dumps({'build': {'id': 'id1'}})) +
+      simulated_buildbucket_output({}) +
       api.override_step_data(
           'test r1.analyze',
           api.json.output({
               'status': 'No dependencies',
               'compile_targets': [],
               'test_targets': [],
           })
       )
   )
 
   yield (
       api.test('compile_affected_targets_only') +
-      props(use_analyze=True) +
+      props(use_analyze=True,
+            buildbucket=json.dumps({'build': {'id': 'id1'}})) +
+      simulated_buildbucket_output({}) +
       api.override_step_data('test r1.read test spec',
                              api.json.output({
                                  'Linux Builder': {
                                      'additional_compile_targets': [
                                          'a', 'a_run',
                                          'b', 'b_run',
                                      ],
                                  }
                              })) +
       api.override_step_data(
@@ skipping 175 matching lines @@
                                  'found': ['target_name'],
                                  'not_found': [],
                              })) +
       api.override_step_data('test r5.check_targets',
                              api.json.output({
                                  'found': ['target_name'],
                                  'not_found': [],
                              })) +
       api.override_step_data('test r5.compile', retcode=1)
   )