Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2088563002: Enable Wextra and Wno-unused-parameters in default cflags (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/prediction/dictionary_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 5bbf6195df155d1917fbfd9700ec758168992fbe..cc2b7ac3325d2698a1757a22342bfcf75c118ef8 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -823,6 +823,8 @@ if (is_clang) {
# code generated by flex (used in angle) contains that keyword.
# http://crbug.com/255186
"-Wno-deprecated-register",
+
+ "-Wno-unused-parameter",
]
# NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
@@ -845,12 +847,7 @@ if (is_clang) {
config("chromium_code") {
cflags = [
"-Wall",
-
- # GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't,
- # so we specify it explicitly.
- # TODO(fischman): remove this if http://llvm.org/PR10448 obsoletes it.
- # http://code.google.com/p/chromium/issues/detail?id=90453
- "-Wsign-compare",
+ "-Wextra",
]
# In Chromium code, we define __STDC_foo_MACROS in order to get the
« no previous file with comments | « no previous file | services/prediction/dictionary_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698