Issue 2088563002: Enable Wextra and Wno-unused-parameters in default cflags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2088563002: Enable Wextra and Wno-unused-parameters in default cflags (Closed)

Created:
4 years, 6 months ago by jamesr

Modified:
4 years, 6 months ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -11 lines)			Patch
M	build/config/compiler/BUILD.gn	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	services/prediction/dictionary_service.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	services/prediction/dictionary_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

jamesr

This matches up more closely with flutter/engine's build settings and enables some generally useful warnings

4 years, 6 months ago (2016-06-21 19:27:40 UTC) #3

jamesr

4 years, 6 months ago (2016-06-21 19:31:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
caa382ebd4d5175136dc148a774e3f0d52294954 (presubmit successful).