Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 208853004: Don't propagate sandbox flags to an opened window unless triggered entirely by script. (Closed)

Created:
6 years, 9 months ago by Nate Chapin
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Don't propagate sandbox flags to an opened window unless triggered entirely by script. This was regressed in http://src.chromium.org/viewvc/blink?revision=161843&view=revision, when we started propagating sandbox flags to new windows via FrameLoader::forceSandboxFlags even if the new window was caused by clicking a link with target="_blank". BUG=353253 TEST=http/tests/navigation/new-window-sandboxed-iframe.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169970

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 13 (0 generated)
Nate Chapin
I should take another stab at cleaning up CreateWindow.cpp. For now, though, a bugfix.
6 years, 9 months ago (2014-03-21 22:51:45 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-24 03:48:42 UTC) #2
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-24 16:40:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/208853004/40001
6 years, 9 months ago (2014-03-24 16:40:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:12:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 17:12:24 UTC) #6
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-24 17:13:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/208853004/40001
6 years, 9 months ago (2014-03-24 17:13:49 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:38:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 17:38:52 UTC) #10
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-25 18:02:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/208853004/40001
6 years, 9 months ago (2014-03-25 18:03:05 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 18:36:04 UTC) #13
Message was sent while issue was closed.
Change committed as 169970

Powered by Google App Engine
This is Rietveld 408576698