Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4899)

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 2088473002: Fix Material Settings Help and Settings redirect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SettingsCrash
Patch Set: git cl format Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_about_handler.cc
diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc
index 3c588812980aa092aca5ba65b62d902168e46ca7..8ecad6cd93f751b406fb3853377f6c6b0ac30047 100644
--- a/chrome/browser/browser_about_handler.cc
+++ b/chrome/browser/browser_about_handler.cc
@@ -95,24 +95,24 @@ bool WillHandleBrowserAboutURL(GURL* url,
#endif
// Redirect chrome://settings, unless MD settings is enabled.
} else if (host == chrome::kChromeUISettingsHost) {
- if (::switches::AboutInSettingsEnabled()) {
- host = chrome::kChromeUISettingsFrameHost;
- } else if (base::FeatureList::IsEnabled(
- features::kMaterialDesignSettingsFeature)) {
+ if (base::FeatureList::IsEnabled(
+ features::kMaterialDesignSettingsFeature)) {
return true; // Prevent further rewriting - this is a valid URL.
+ } else if (::switches::AboutInSettingsEnabled()) {
+ host = chrome::kChromeUISettingsFrameHost;
} else {
host = chrome::kChromeUIUberHost;
path = chrome::kChromeUISettingsHost + url->path();
}
// Redirect chrome://help, unless MD settings is enabled.
} else if (host == chrome::kChromeUIHelpHost) {
- if (::switches::AboutInSettingsEnabled()) {
+ if (base::FeatureList::IsEnabled(
+ features::kMaterialDesignSettingsFeature)) {
+ return true; // Prevent further rewriting - this is a valid URL.
+ } else if (::switches::AboutInSettingsEnabled()) {
host = chrome::kChromeUISettingsFrameHost;
if (url->path().empty() || url->path() == "/")
path = chrome::kChromeUIHelpHost;
- } else if (base::FeatureList::IsEnabled(
- features::kMaterialDesignSettingsFeature)) {
- return true; // Prevent further rewriting - this is a valid URL.
} else {
host = chrome::kChromeUIUberHost;
path = chrome::kChromeUIHelpHost + url->path();
« no previous file with comments | « no previous file | chrome/browser/browser_about_handler_unittest.cc » ('j') | chrome/browser/browser_about_handler_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698