Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2088453003: Move GLSurface and rename source files. (Closed)

Created:
4 years, 6 months ago by kylechar
Modified:
4 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GLSurface and rename source files. Move the GLSurface implementations for Ozone from //ui/gl to //ui/gl/init as part of breaking the dependency from //ui/gl on //ui/ozone. These classes will later be refactored and moved back to //ui/gl without any Ozone dependencies. Also rename the files that contain the platform specific implementation of GetPlatformDefaultEGLNativeDisplay() to be more appropriate. BUG=611142 Committed: https://crrev.com/9aeb4ff4c64befeafe6f0942921aafa989b6a90b Cr-Commit-Position: refs/heads/master@{#401093}

Patch Set 1 #

Patch Set 2 : Formatting. #

Patch Set 3 : Fix GYP path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -802 lines) Patch
M ui/gl/BUILD.gn View 1 4 chunks +3 lines, -5 lines 0 comments Download
M ui/gl/gl.gyp View 2 chunks +3 lines, -5 lines 0 comments Download
D ui/gl/gl_surface_android.cc View 1 chunk +0 lines, -16 lines 0 comments Download
A + ui/gl/gl_surface_egl_android.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
A ui/gl/gl_surface_egl_ozone.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + ui/gl/gl_surface_egl_win.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M ui/gl/gl_surface_egl_x11.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_overlay.h View 1 chunk +2 lines, -1 line 0 comments Download
D ui/gl/gl_surface_ozone.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/gl/gl_surface_ozone.cc View 1 chunk +0 lines, -699 lines 0 comments Download
D ui/gl/gl_surface_win.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/gl/gl_surface_x11.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M ui/gl/init/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/init/gl_factory_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/init/gl_init.gyp View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
A ui/gl/init/gl_surface_ozone.h View 1 chunk +31 lines, -0 lines 0 comments Download
A + ui/gl/init/gl_surface_ozone.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kylechar
4 years, 6 months ago (2016-06-21 12:50:56 UTC) #2
piman
lgtm
4 years, 6 months ago (2016-06-21 15:03:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088453003/20001
4 years, 6 months ago (2016-06-21 16:46:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/188992)
4 years, 6 months ago (2016-06-21 16:54:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088453003/40001
4 years, 6 months ago (2016-06-21 19:08:41 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-21 20:29:17 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 20:33:52 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9aeb4ff4c64befeafe6f0942921aafa989b6a90b
Cr-Commit-Position: refs/heads/master@{#401093}

Powered by Google App Engine
This is Rietveld 408576698