third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp - Issue 2088453002: Implement the inert attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

Issue 2088453002: Implement the inert attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update generic test expectations Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/accessibility/AXObject.cpp ('K') | « third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h ('k') | third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

index 418ac16c9f861a85d3b7e8e5e82989b4a08eb27f..ab1df730d37a9291870217179eb02d46ac8707da 100644

--- a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

@@ -723,10 +723,11 @@ void InspectorAccessibilityAgent::AddChildren(

child_ids->addItem(String::Number(child_ax_object.AxObjectID()));

if (&child_ax_object == inspected_ax_object)

continue;

- if (&ax_object != inspected_ax_object &&

- (ax_object.GetNode() ||

- ax_object.ParentObjectUnignored() != inspected_ax_object)) {

- continue;

+ if (&ax_object != inspected_ax_object) {

+ if (!inspected_ax_object)

+ continue;

+ if (&ax_object != inspected_ax_object->ParentObjectUnignored())

+ continue;

}

// Only add children of inspected node (or un-inspectable children of