third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp - Issue 2088453002: Implement the inert attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2088453002: Implement the inert attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update generic test expectations Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/accessibility/AXObject.cpp ('K') | « third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h ('k') | third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

index 4f14f3e06d7d086d7831e67c7dd784f6ffde375d..b90b45c2dbcd3216e4eed5a598134e9d96ab3a88 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

@@ -38,6 +38,7 @@

#include "core/frame/Settings.h"

#include "core/html/HTMLAreaElement.h"

#include "core/html/HTMLCanvasElement.h"

+#include "core/html/HTMLFrameOwnerElement.h"

#include "core/html/HTMLImageElement.h"

#include "core/html/HTMLInputElement.h"

#include "core/html/HTMLLabelElement.h"

@@ -588,11 +589,8 @@ void AXObjectCacheImpl::TextChanged(AXObject* obj) {

if (!obj)

return;

- bool parent_already_exists = obj->ParentObjectIfExists();

obj->TextChanged();

PostNotification(obj, AXObjectCacheImpl::kAXTextChanged);

- if (parent_already_exists)

- obj->NotifyIfIgnoredValueChanged();

}

void AXObjectCacheImpl::UpdateCacheAfterNodeIsAttached(Node* node) {