Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp

Issue 2088453002: Implement the inert attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Logspammy WIP Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp b/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
index 713c4e5c42bba37376d8b1e4897eff9c3cd1b52b..8e7332da5a64722ab513fefb2412b69833ac1fd1 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
@@ -66,9 +66,13 @@ AXMenuListOption* AXMenuListPopup::MenuListOptionAXObject(
return 0;
AXObject* object = AxObjectCache().GetOrCreate(element);
- if (!object || !object->IsMenuListOption())
+ LOG(INFO) << "Created " << object;
+ if (!object || !object->IsMenuListOption()) {
+ LOG(INFO) << "!object || !object->IsMenuListOption(): " << object;
return 0;
+ }
+ LOG(INFO) << "Returning object " << object;
return ToAXMenuListOption(object);
}
@@ -108,15 +112,25 @@ void AXMenuListPopup::AddChildren() {
active_index_ = GetSelectedIndex();
for (const auto& option_element : html_select_element->GetOptionList()) {
+ LOG(INFO) << "Getting option for element";
AXMenuListOption* option = MenuListOptionAXObject(option_element);
+ LOG(INFO) << "Got option: " << option;
if (option) {
+ LOG(INFO) << "Setting parent on option " << option;
option->SetParent(this);
children_.push_back(option);
+ } else {
+ LOG(INFO) << "no option";
}
}
}
void AXMenuListPopup::UpdateChildrenIfNecessary() {
+ LOG(INFO) << "AXMenuListPopup::UpdateChildrenIfNecessary";
+ LOG(INFO) << "have_children_: " << have_children_ << "; parent_: " << parent_;
+ if (parent_)
+ LOG(INFO) << "parent_->NeedsToUpdateChildren(): "
+ << parent_->NeedsToUpdateChildren();
if (have_children_ && parent_ && parent_->NeedsToUpdateChildren())
ClearChildren();

Powered by Google App Engine
This is Rietveld 408576698