Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2088453002: Implement the inert attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Logspammy WIP Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Node.cpp
diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp
index 7d8415f0b1a934c007004df3e9fc46dcb54354ce..be953cac6736f98a354fd1e0d7d34f814856b18d 100644
--- a/third_party/WebKit/Source/core/dom/Node.cpp
+++ b/third_party/WebKit/Source/core/dom/Node.cpp
@@ -828,11 +828,27 @@ bool Node::ShouldHaveFocusAppearance() const {
}
bool Node::IsInert() const {
+ if (!CanParticipateInFlatTree())
+ return true;
+
+ DCHECK(!ChildNeedsDistributionRecalc());
+
const HTMLDialogElement* dialog = GetDocument().ActiveModalDialog();
if (dialog && this != GetDocument() &&
- (!CanParticipateInFlatTree() ||
- !FlatTreeTraversal::ContainsIncludingPseudoElement(*dialog, *this)))
+ !FlatTreeTraversal::ContainsIncludingPseudoElement(*dialog, *this)) {
return true;
+ }
+
+ if (RuntimeEnabledFeatures::inertAttributeEnabled()) {
+ const Element* element = this->IsElementNode()
+ ? ToElement(this)
+ : FlatTreeTraversal::ParentElement(*this);
+ while (element) {
+ if (element->hasAttribute(HTMLNames::inertAttr))
+ return true;
+ element = FlatTreeTraversal::ParentElement(*element);
+ }
+ }
return GetDocument().LocalOwner() && GetDocument().LocalOwner()->IsInert();
dmazzoni 2017/05/08 06:06:09 I just realized this only walks local frames, so i
}

Powered by Google App Engine
This is Rietveld 408576698