third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js - Issue 2088453002: Implement the inert attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js

Issue 2088453002: Implement the inert attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dmazzoni comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLElement.idl ('k') | third_party/WebKit/Source/modules/accessibility/AXObject.h » ('j') | third_party/WebKit/Source/modules/accessibility/AXObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js

index 5bdfdc3bf8f6d47ff303977b843d63b735f311d7..fff8506e3325aec9264cc26bfa1b1cad4ea2b0d7 100644

--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js

@@ -588,11 +588,11 @@ Accessibility.AXNodeIgnoredReasonTreeElement = class extends Accessibility.AXNod

case 'ancestorIsLeafNode':

reasonElement = UI.formatLocalized('Ancestor\'s children are all presentational:\u00a0', []);

break;

- case 'ariaHidden':

+ case 'ariaHiddenElement':

var ariaHiddenSpan = createElement('span', 'source-code').textContent = 'aria-hidden';

reasonElement = UI.formatLocalized('Element is %s.', [ariaHiddenSpan]);

break;

- case 'ariaHiddenRoot':

+ case 'ariaHiddenSubTree':

var ariaHiddenSpan = createElement('span', 'source-code').textContent = 'aria-hidden';

var trueSpan = createElement('span', 'source-code').textContent = 'true';

reasonElement = UI.formatLocalized('%s is %s on ancestor:\u00a0', [ariaHiddenSpan, trueSpan]);

@@ -603,9 +603,12 @@ Accessibility.AXNodeIgnoredReasonTreeElement = class extends Accessibility.AXNod

case 'emptyText':

reasonElement = UI.formatLocalized('No text content.', []);

break;

- case 'inert':

+ case 'inertElement':

reasonElement = UI.formatLocalized('Element is inert.', []);

break;

+ case 'inertSubtree':

+ reasonElement = UI.formatLocalized('Element is in an inert subtree from\u00a0', []);

+ break;

case 'inheritsPresentation':

reasonElement = UI.formatLocalized('Element inherits presentational role from\u00a0', []);

break;