Implement the inert attribute

third_party/WebKit/Source/modules/accessibility/AXObject.cpp

 /*
  * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 515 matching lines @@
     case kSpinButtonRole:
     case kTabRole:
     case kTextFieldRole:
     case kToggleButtonRole:
       return true;
     default:
       return false;
   }
 }
 
-bool AXObject::AccessibilityIsIgnored() const {
+bool AXObject::AccessibilityIsIgnored() {
+  Node* node = GetNode();
+  if (!node) {
+    AXObject* parent = this->ParentObject();
+    while (!node && parent) {
+      node = parent->GetNode();
+      parent = parent->ParentObject();
+    }
+  }
+
+  if (node)
+    node->UpdateDistribution();
+
+  // TODO(aboxhall): Instead of this, propagate inert down through frames
+  Document* document = GetDocument();
+  if (document && document->LocalOwner())
+    document->LocalOwner()->UpdateDistribution();

[esprehn, 2017/05/12 21:16:54]

Why are you updating the distribution of the parent iframe? This doesn't go all
the way up, so I suspect it still doesn't work if you're multiple levels down in
distributed frames.

[aboxhall, 2017/05/18 01:30:49]

It crashes (DCHECK fails) without this in certain situations. I should probably
walk all the way up in case there are crashes we're missing in tests.

+
   UpdateCachedAttributeValuesIfNeeded();
   return cached_is_ignored_;
 }
 
 void AXObject::UpdateCachedAttributeValuesIfNeeded() const {
   if (IsDetached())
     return;
 
   AXObjectCacheImpl& cache = AxObjectCache();
 
@@ skipping 61 matching lines @@
   if (GetNode()) {
     if (GetNode()->IsInert()) {
       if (ignored_reasons) {
         HTMLDialogElement* dialog = GetActiveDialogElement(GetNode());
         if (dialog) {
           AXObject* dialog_object = AxObjectCache().GetOrCreate(dialog);
           if (dialog_object)
             ignored_reasons->push_back(
                 IgnoredReason(kAXActiveModalDialog, dialog_object));
           else
-            ignored_reasons->push_back(IgnoredReason(kAXInert));
+            ignored_reasons->push_back(IgnoredReason(kAXInertElement));
         } else {
-          // TODO(aboxhall): handle inert attribute if it eventuates
-          ignored_reasons->push_back(IgnoredReason(kAXInert));
+          const AXObject* inert_root_el = InertRoot();
+          if (inert_root_el == this) {
+            ignored_reasons->push_back(IgnoredReason(kAXInertElement));
+          } else {
+            ignored_reasons->push_back(
+                IgnoredReason(kAXInertSubtree, inert_root_el));
+          }
         }
       }
       return true;
     }
   } else {
     AXObject* parent = ParentObject();
     if (parent && parent->IsInertOrAriaHidden()) {
       if (ignored_reasons)
         parent->ComputeIsInertOrAriaHidden(ignored_reasons);
       return true;
     }
   }
 
   const AXObject* hidden_root = AriaHiddenRoot();
   if (hidden_root) {
     if (ignored_reasons) {
-      if (hidden_root == this)
-        ignored_reasons->push_back(IgnoredReason(kAXAriaHidden));
-      else
+      if (hidden_root == this) {
+        ignored_reasons->push_back(IgnoredReason(kAXAriaHiddenElement));
+      } else {
         ignored_reasons->push_back(
-            IgnoredReason(kAXAriaHiddenRoot, hidden_root));
+            IgnoredReason(kAXAriaHiddenSubtree, hidden_root));
+      }
     }
     return true;
   }
 
   return false;
 }
 
 bool AXObject::IsDescendantOfLeafNode() const {
   UpdateCachedAttributeValuesIfNeeded();
   return cached_is_descendant_of_leaf_node_;
@@ skipping 12 matching lines @@
 
 const AXObject* AXObject::AriaHiddenRoot() const {
   for (const AXObject* object = this; object; object = object->ParentObject()) {
     if (EqualIgnoringASCIICase(object->GetAttribute(aria_hiddenAttr), "true"))
       return object;
   }
 
   return 0;
 }
 
+const AXObject* AXObject::InertRoot() const {
+  const AXObject* object = this;
+  if (!RuntimeEnabledFeatures::inertAttributeEnabled())
+    return 0;
+
+  while (object && !object->IsAXNodeObject())
+    object = object->ParentObject();
+  Node* node = object->GetNode();
+  Element* element = node->IsElementNode()
+                         ? ToElement(node)
+                         : FlatTreeTraversal::ParentElement(*node);

[esprehn, 2017/05/12 21:16:54]

You could add FlatTreeTraversal::ParentElementOrSelf(node) and use it here and
elsewhere.

[aboxhall, 2017/05/18 01:30:49]

This actually doesn't seem to be a super common case, so I'll leave it as-is.

+  while (element) {
+    if (element->hasAttribute(inertAttr))
+      return AxObjectCache().GetOrCreate(element);
+    element = FlatTreeTraversal::ParentElement(*element);
+  }
+
+  return 0;
+}
+
 bool AXObject::IsDescendantOfDisabledNode() const {
   UpdateCachedAttributeValuesIfNeeded();
   return cached_is_descendant_of_disabled_node_;
 }
 
 const AXObject* AXObject::DisabledAncestor() const {
   const AtomicString& disabled = GetAttribute(aria_disabledAttr);
   if (EqualIgnoringASCIICase(disabled, "true"))
     return this;
   if (EqualIgnoringASCIICase(disabled, "false"))
@@ skipping 524 matching lines @@
 void AXObject::ClearChildren() {
   // Detach all weak pointers from objects to their parents.
   for (const auto& child : children_)
     child->DetachFromParent();
 
   children_.clear();
   have_children_ = false;
 }
 
 Document* AXObject::GetDocument() const {
-  FrameView* frame_view = DocumentFrameView();
-  if (!frame_view)
-    return 0;
-
-  return frame_view->GetFrame().GetDocument();
+  return &(AxObjectCache().GetDocument());
 }
 
 FrameView* AXObject::DocumentFrameView() const {
   const AXObject* object = this;
   while (object && !object->IsAXLayoutObject())
     object = object->ParentObject();
 
   if (!object)
     return 0;
 
@@ skipping 628 matching lines @@
 }
 
 DEFINE_TRACE(AXObject) {
   visitor->Trace(children_);
   visitor->Trace(parent_);
   visitor->Trace(cached_live_region_root_);
   visitor->Trace(ax_object_cache_);
 }
 
 }  // namespace blink