Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2088453002: Implement the inert attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Logspammy WIP Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights
7 * reserved. 7 * reserved.
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2010 Google Inc. All rights reserved. 9 * Copyright (C) 2010 Google Inc. All rights reserved.
10 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 10 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 SetOptionsChangedOnLayoutObject(); 736 SetOptionsChangedOnLayoutObject();
737 if (!isConnected()) { 737 if (!isConnected()) {
738 if (HTMLOptionsCollection* collection = 738 if (HTMLOptionsCollection* collection =
739 CachedCollection<HTMLOptionsCollection>(kSelectOptions)) 739 CachedCollection<HTMLOptionsCollection>(kSelectOptions))
740 collection->InvalidateCache(); 740 collection->InvalidateCache();
741 InvalidateSelectedItems(); 741 InvalidateSelectedItems();
742 } 742 }
743 743
744 if (GetLayoutObject()) { 744 if (GetLayoutObject()) {
745 if (AXObjectCache* cache = 745 if (AXObjectCache* cache =
746 GetLayoutObject()->GetDocument().ExistingAXObjectCache()) 746 GetLayoutObject()->GetDocument().ExistingAXObjectCache()) {
747 LOG(INFO) << "Calling childrenChanged";
747 cache->ChildrenChanged(this); 748 cache->ChildrenChanged(this);
749 return;
750 }
748 } 751 }
752 LOG(INFO) << "Didn't call childrenChanged";
749 } 753 }
750 754
751 void HTMLSelectElement::RecalcListItems() const { 755 void HTMLSelectElement::RecalcListItems() const {
752 TRACE_EVENT0("blink", "HTMLSelectElement::recalcListItems"); 756 TRACE_EVENT0("blink", "HTMLSelectElement::recalcListItems");
753 list_items_.resize(0); 757 list_items_.resize(0);
754 758
755 should_recalc_list_items_ = false; 759 should_recalc_list_items_ = false;
756 760
757 for (Element* current_element = ElementTraversal::FirstWithin(*this); 761 for (Element* current_element = ElementTraversal::FirstWithin(*this);
758 current_element && list_items_.size() < kMaxListItems;) { 762 current_element && list_items_.size() < kMaxListItems;) {
(...skipping 1300 matching lines...) Expand 10 before | Expand all | Expand 10 after
2059 popup_updater_ = nullptr; 2063 popup_updater_ = nullptr;
2060 } 2064 }
2061 2065
2062 void HTMLSelectElement::DidMutateSubtree() { 2066 void HTMLSelectElement::DidMutateSubtree() {
2063 DCHECK(PopupIsVisible()); 2067 DCHECK(PopupIsVisible());
2064 DCHECK(popup_); 2068 DCHECK(popup_);
2065 popup_->UpdateFromElement(PopupMenu::kByDOMChange); 2069 popup_->UpdateFromElement(PopupMenu::kByDOMChange);
2066 } 2070 }
2067 2071
2068 } // namespace blink 2072 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698