third_party/WebKit/LayoutTests/fast/dom/inert/inert-focus-in-frames.html - Issue 2088453002: Implement the inert attribute

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/inert/inert-focus-in-frames.html

Issue 2088453002: Implement the inert attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dmazzoni comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/dom/inert/inert-does-not-match-disabled-selector.html ('K') | « third_party/WebKit/LayoutTests/fast/dom/inert/inert-does-not-match-disabled-selector.html ('k') | third_party/WebKit/LayoutTests/fast/dom/inert/inert-inlines.html » ('j') | third_party/WebKit/Source/core/dom/Node.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../../resources/testharness.js"></script>

	5 <script src="../../../resources/testharnessreport.js"></script>

	6 </head>

	7 <body>

	8

	9 <div inert>

	10 <iframe height=400 width=600 id="main-iframe">
	esprehn 2017/02/07 23:50:59 iframe doesn't accept children, I'm not sure I und iframe doesn't accept children, I'm not sure I understand this test. aboxhall 2017/02/08 05:26:01 Copied from the more or less identical dialog test Show quoted text On 2017/02/07 23:50:59, esprehn wrote: > iframe doesn't accept children, I'm not sure I understand this test. Copied from the more or less identical dialog test: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/html/dial... What happens is that the script below takes the descendant content and writes it into the iframe's contentDocument (line 47).
	11 <frameset rows="*" cols="50,50">
	esprehn 2017/02/07 23:50:59 frameset isn't valid here, what are you testing? frameset isn't valid here, what are you testing? aboxhall 2017/02/08 05:26:01 See previous comment. Show quoted text On 2017/02/07 23:50:59, esprehn wrote: > frameset isn't valid here, what are you testing? See previous comment.
	12 <frame src="resources/inert-focus-in-frames-frame1.html">

	13 <frame src='data:text/html,<div id="frame2-div" class="target" tabindex="0"> Hello</div>'>

	14 </frameset>

	15 </iframe>

	16 </div>

	17

	18 <script>

	19 setup({ explicit_done: true });

	20

	21 framesLoaded = 0;

	22 numFrames = 4;

	23 var mainIframe = document.getElementById('main-iframe');

	24

	25 function frameLoaded() {

	26 framesLoaded++;

	27 if (framesLoaded == numFrames) {

	28 test(function() {

	29 var frame1 = mainIframe.contentWindow.frames[0].document;

	30 var target1 = frame1.querySelector('.target');

	31 testCantFocus(target1);

	32 var iframe = frame1.querySelector('iframe').contentDocument;

	33 testCantFocus(iframe.querySelector('.target'));

	34 }, "Focus can't go into frames or iframes in inert subtree");

	35 done();

	36 }

	37 }

	38

	39 function testCantFocus(element) {

	40 focusedElement = null;

	41 element.addEventListener('focus', function() { focusedElement = element; }, false);

	42 element.focus();

	43 theElement = element;

	44 assert_false(focusedElement === theElement);

	45 }

	46

	47 mainIframe.contentDocument.write(mainIframe.textContent);

	48 mainIframe.contentDocument.close();

	49

	50 mainIframe.contentWindow.frames[1].window.onload = frameLoaded;

	51

	52 window.onload = frameLoaded;

	53 </script>

	54 </body>

	55 </html>

OLD	NEW