Implement the inert attribute

third_party/WebKit/Source/modules/accessibility/AXObject.cpp

 /*
  * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 515 matching lines @@
 
 bool AXObject::computeIsInertOrAriaHidden(
     IgnoredReasons* ignoredReasons) const {
   if (getNode()) {
     if (getNode()->isInert()) {
       if (ignoredReasons) {
         HTMLDialogElement* dialog = getActiveDialogElement(getNode());
         if (dialog) {
           AXObject* dialogObject = axObjectCache().getOrCreate(dialog);
           if (dialogObject)
-            ignoredReasons->push_back(
+            ignoredReasons->append(
                 IgnoredReason(AXActiveModalDialog, dialogObject));
           else
-            ignoredReasons->push_back(IgnoredReason(AXInert));
+            ignoredReasons->append(IgnoredReason(AXInertElement));
         } else {
-          // TODO(aboxhall): handle inert attribute if it eventuates
-          ignoredReasons->push_back(IgnoredReason(AXInert));
+          const AXObject* inertRootEl = inertRoot();
+          if (inertRootEl == this)
+            ignoredReasons->append(IgnoredReason(AXInertElement));
+          else
+            ignoredReasons->append(IgnoredReason(AXInertSubtree, inertRootEl));
         }
       }
       return true;
     }
   } else {
     AXObject* parent = parentObject();
     if (parent && parent->isInertOrAriaHidden()) {
       if (ignoredReasons)
         parent->computeIsInertOrAriaHidden(ignoredReasons);
       return true;
     }
   }
 
   const AXObject* hiddenRoot = ariaHiddenRoot();
   if (hiddenRoot) {
     if (ignoredReasons) {
-      if (hiddenRoot == this)
-        ignoredReasons->push_back(IgnoredReason(AXAriaHidden));
-      else
-        ignoredReasons->push_back(IgnoredReason(AXAriaHiddenRoot, hiddenRoot));
+      if (hiddenRoot == this) {
+        ignoredReasons->push_back(IgnoredReason(AXAriaHiddenElement));
+      } else {
+        ignoredReasons->push_back(
+            IgnoredReason(AXAriaHiddenSubtree, hiddenRoot));
+      }
     }
     return true;
   }
 
   return false;
 }
 
 bool AXObject::isDescendantOfLeafNode() const {
   updateCachedAttributeValuesIfNeeded();
   return m_cachedIsDescendantOfLeafNode;
@@ skipping 12 matching lines @@
 
 const AXObject* AXObject::ariaHiddenRoot() const {
   for (const AXObject* object = this; object; object = object->parentObject()) {
     if (equalIgnoringCase(object->getAttribute(aria_hiddenAttr), "true"))
       return object;
   }
 
   return 0;
 }
 
+const AXObject* AXObject::inertRoot() const {
+  const AXObject* object = this;
+  while (object && !object->isAXNodeObject())
+    object = object->parentObject();
+  for (Node* node = object->getNode(); node; node = node->parentNode()) {

[dmazzoni, 2017/01/18 16:38:54]

I'm assuming this should also be parentOrShadowHostElement()?

We should probably change this throughout modules/accessibility/
but for sure do it in this change to be consistent.

[aboxhall, 2017/01/19 02:44:26]

Ah yep, good catch, thanks.

+    if (!node->isElementNode())
+      continue;
+    if (toElement(node)->hasAttribute(inertAttr))

[dmazzoni, 2017/01/18 16:38:54]

Need to check RuntimeEnabledFeatures here too

[aboxhall, 2017/01/19 02:44:26]

Hm - probably doesn't matter in practice, since this is only called if
node->isInert() returns true, but definitely best to be safe.

+      return axObjectCache().getOrCreate(node);
+  }
+
+  return 0;
+}
+
 bool AXObject::isDescendantOfDisabledNode() const {
   updateCachedAttributeValuesIfNeeded();
   return m_cachedIsDescendantOfDisabledNode;
 }
 
 const AXObject* AXObject::disabledAncestor() const {
   const AtomicString& disabled = getAttribute(aria_disabledAttr);
   if (equalIgnoringCase(disabled, "true"))
     return this;
   if (equalIgnoringCase(disabled, "false"))
@@ skipping 1141 matching lines @@
 }
 
 DEFINE_TRACE(AXObject) {
   visitor->trace(m_children);
   visitor->trace(m_parent);
   visitor->trace(m_cachedLiveRegionRoot);
   visitor->trace(m_axObjectCache);
 }
 
 }  // namespace blink