Implement the inert attribute

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  *
@@ skipping 735 matching lines @@
   for (Node* node = ParentOrShadowHostNode();
        node && !node->ChildNeedsStyleInvalidation();
        node = node->ParentOrShadowHostNode())
     node->SetChildNeedsStyleInvalidation();
   GetDocument().ScheduleLayoutTreeUpdateIfNeeded();
 }
 
 void Node::MarkAncestorsWithChildNeedsDistributionRecalc() {
   ScriptForbiddenScope forbid_script_during_raw_iteration;
   for (Node* node = this; node && !node->ChildNeedsDistributionRecalc();
-       node = node->ParentOrShadowHostNode())
+       node = node->ParentOrShadowHostNode()) {
     node->SetChildNeedsDistributionRecalc();
+  }
   GetDocument().ScheduleLayoutTreeUpdateIfNeeded();
 }
 
 inline void Node::SetStyleChange(StyleChangeType change_type) {
   node_flags_ = (node_flags_ & ~kStyleChangeMask) | change_type;
 }
 
 void Node::MarkAncestorsWithChildNeedsStyleRecalc() {
   for (ContainerNode* p = ParentOrShadowHostNode();
        p && !p->ChildNeedsStyleRecalc(); p = p->ParentOrShadowHostNode())
@@ skipping 70 matching lines @@
 
 Node* Node::FocusDelegate() {
   return this;
 }
 
 bool Node::ShouldHaveFocusAppearance() const {
   DCHECK(IsFocused());
   return true;
 }
 
 bool Node::IsInert() const {

[kochi, 2017/05/22 07:31:15]

Could you also update the comment in Node.h above IsInert(),
if necessary?
I think including a link to the explainer or whatever
you think is the most relevant information would be good.

[aboxhall, 2017/05/23 02:45:43]

Added some links in the .h

+  if (!CanParticipateInFlatTree())
+    return true;
+
+  if (!isConnected())

[kochi, 2017/05/22 07:31:15]

style nit: you can combine line 850 and 853 into one condition - I prefer
that for readability, but this is very personal opinion and you can ignore
this comment.

[aboxhall, 2017/05/23 02:45:43]

Makes sense, done.

+    return true;
+
+  DCHECK(!ChildNeedsDistributionRecalc());
+
   const HTMLDialogElement* dialog = GetDocument().ActiveModalDialog();
   if (dialog && this != GetDocument() &&
-      (!CanParticipateInFlatTree() ||
-       !FlatTreeTraversal::ContainsIncludingPseudoElement(*dialog, *this)))
+      !FlatTreeTraversal::ContainsIncludingPseudoElement(*dialog, *this)) {
     return true;
+  }
+
+  if (RuntimeEnabledFeatures::inertAttributeEnabled()) {
+    const Element* element = this->IsElementNode()
+                                 ? ToElement(this)
+                                 : FlatTreeTraversal::ParentElement(*this);
+    while (element) {
+      if (element->hasAttribute(HTMLNames::inertAttr))
+        return true;
+      element = FlatTreeTraversal::ParentElement(*element);
+    }
+  }
   return GetDocument().LocalOwner() && GetDocument().LocalOwner()->IsInert();
 }
 
 unsigned Node::NodeIndex() const {
   const Node* temp_node = previousSibling();
   unsigned count = 0;
   for (count = 0; temp_node; count++)
     temp_node = temp_node->previousSibling();
   return count;
 }
@@ skipping 1759 matching lines @@
   if (node) {
     std::stringstream stream;
     node->PrintNodePathTo(stream);
     LOG(INFO) << stream.str();
   } else {
     LOG(INFO) << "Cannot showNodePath for <null>";
   }
 }
 
 #endif