Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: components/sessions/content/content_platform_specific_tab_data.h

Issue 2088443003: Shortcut ctrl+shift+T added on android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix issues based on feedback. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/content/content_platform_specific_tab_data.h
diff --git a/components/sessions/content/content_platform_specific_tab_data.h b/components/sessions/content/content_platform_specific_tab_data.h
index 1ccc6dd7c64448a5293bf466763f38a0cf73ecb7..1ad05051e5f3c77abfef372b90444ee07cd98a73 100644
--- a/components/sessions/content/content_platform_specific_tab_data.h
+++ b/components/sessions/content/content_platform_specific_tab_data.h
@@ -31,11 +31,22 @@ class SESSIONS_EXPORT ContentPlatformSpecificTabData
return session_storage_namespace_.get();
}
+ SessionID::id_type window_id() const {
+ return window_id_;
sky 2016/06/24 15:54:22 Can you elaborate on why you need to add this here
xingliu 2016/06/24 16:48:44 Thank you for the feedback, The window_id here is
xingliu 2016/06/24 17:52:29 Or I can add function to access TabRestoreService:
+ }
+
+ void SetWindowId(SessionID::id_type id) {
sky 2016/06/24 15:54:22 set_window_id
xingliu 2016/06/24 16:48:44 Will be fixed shortly.
+ window_id_ = id;
+ }
+
private:
// PlatformSpecificTabData:
std::unique_ptr<PlatformSpecificTabData> Clone() override;
scoped_refptr<content::SessionStorageNamespace> session_storage_namespace_;
+
+ // used to match android tab model id.
+ SessionID::id_type window_id_;
sky 2016/06/24 15:54:22 This needs to be initialized in the member initial
xingliu 2016/06/24 16:48:44 Will be fixed shortly.
};
} // namespace sessions

Powered by Google App Engine
This is Rietveld 408576698