chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc - Issue 2088443003: Shortcut ctrl+shift+T added on android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

Issue 2088443003: Shortcut ctrl+shift+T added on android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit fixes based on review. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

diff --git a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

index 19dcfc582d63b85778cae1c9766b370993c56ed3..e42c0756b5e9f33ba5ed7e1cf5c9db1c9e6fadab 100644

--- a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

+++ b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

@@ -87,7 +87,7 @@ void TabModelJniBridge::CreateTab(TabAndroid* parent,

JNIEnv* env = AttachCurrentThread();

Java_TabModelJniBridge_createTabWithWebContents(

env, java_object_.get(env).obj(),

- parent->GetJavaObject().obj(),

+ (parent ? parent->GetJavaObject().obj() : NULL),

David Trainor- moved to gerrit 2016/07/14 18:25:53 nullptr? Or does that cause issues with the JNI m

web_contents->GetBrowserContext()->IsOffTheRecord(),

web_contents->GetJavaWebContents().obj(),

parent_tab_id);