chrome/browser/android/tab_android.cc - Issue 2088443003: Shortcut ctrl+shift+T added on android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.cc

Issue 2088443003: Shortcut ctrl+shift+T added on android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes based on review feedback. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/tab_android.cc

diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc

index efd00c4aaab7e2cf4591d60c291f952945b7cf13..9e1079b104434d63273b18ee93606dfce3fd0242 100644

--- a/chrome/browser/android/tab_android.cc

+++ b/chrome/browser/android/tab_android.cc

@@ -97,8 +97,10 @@ using content::WebContents;

using navigation_interception::InterceptNavigationDelegate;

using navigation_interception::NavigationParams;

-TabAndroid* TabAndroid::FromWebContents(content::WebContents* web_contents) {

- CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(web_contents);

+TabAndroid* TabAndroid::FromWebContents(

+ const content::WebContents* web_contents) {

Theresa 2016/06/30 20:50:25 Does this still need to be const or is this left o

xingliu 2016/07/01 00:30:38 Yes.

+ const CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(

+ web_contents);

if (!core_tab_helper)

return NULL;