Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4266)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

Issue 2088443003: Shortcut ctrl+shift+T added on android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add incognito check in native code, based on code review feedback. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java b/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
index d8a3cc1c854c3905b6761523e69972b6ccafea55..dec342700fda1daa00c02d080d3736967d50f661 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
@@ -123,6 +123,11 @@ public class KeyboardShortcuts {
int keyCodeAndMeta = keyCode | metaState;
switch (keyCodeAndMeta) {
+ case CTRL | SHIFT | KeyEvent.KEYCODE_T:
+ if (!curModel.isIncognito()) {
+ activity.onMenuOrKeyboardAction(R.id.open_recent_closed_tab, false);
Theresa 2016/06/29 23:53:29 Let's have this just call into the activity and th
xingliu 2016/06/30 05:43:55 Done.
+ }
+ return true;
case CTRL | KeyEvent.KEYCODE_T:
activity.onMenuOrKeyboardAction(curModel.isIncognito()
? R.id.new_incognito_tab_menu_id

Powered by Google App Engine
This is Rietveld 408576698