Shortcut ctrl+shift+T added on android.

chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.tabmodel;
 
 import org.chromium.base.ContextUtils;
 import org.chromium.base.ObserverList;
 import org.chromium.base.TraceEvent;
 import org.chromium.chrome.browser.ChromeTabbedActivity;
 import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;
+import org.chromium.chrome.browser.ntp.RecentlyClosedBridge;
 import org.chromium.chrome.browser.partnercustomizations.HomepageManager;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator;
 import org.chromium.chrome.browser.util.MathUtils;
 import org.chromium.content_public.browser.WebContents;
 
 import java.util.ArrayList;
 import java.util.List;
 
 /**
@@ skipping 16 matching lines @@
     private final List<Tab> mTabs = new ArrayList<Tab>();
 
     private final TabCreator mRegularTabCreator;
     private final TabCreator mIncognitoTabCreator;
     private final TabModelSelectorUma mUma;
     private final TabModelOrderController mOrderController;
     private final TabContentManager mTabContentManager;
     private final TabPersistentStore mTabSaver;
     private final TabModelDelegate mModelDelegate;
     private final ObserverList<TabModelObserver> mObservers;
+    private RecentlyClosedBridge mRecentlyClosedBridge;
 
     // Undo State Tracking -------------------------------------------------------------------------
 
     /**
      * A {@link TabList} that represents the complete list of {@link Tab}s. This is so that
      * certain UI elements can call {@link TabModel#getComprehensiveModel()} to get a full list of
      * {@link Tab}s that includes rewindable entries, as the typical {@link TabModel} does not
      * return rewindable entries.
      */
     private final RewoundList mRewoundList = new RewoundList();
@@ skipping 16 matching lines @@
         initializeNative();
         mRegularTabCreator = regularTabCreator;
         mIncognitoTabCreator = incognitoTabCreator;
         mUma = uma;
         mOrderController = orderController;
         mTabContentManager = tabContentManager;
         mTabSaver = tabSaver;
         mModelDelegate = modelDelegate;
         mIsUndoSupported = supportUndo;
         mObservers = new ObserverList<TabModelObserver>();
+        mRecentlyClosedBridge = new RecentlyClosedBridge(getProfile());
     }
 
     @Override
     public void removeTab(Tab tab) {
         removeTabAndSelectNext(tab, TabSelectionType.FROM_USER, false, true);
 
         for (TabModelObserver obs : mObservers) obs.tabRemoved(tab);
     }
 
     @Override
     public void destroy() {
         for (Tab tab : mTabs) {
             if (tab.isInitialized()) tab.destroy();
         }
 
         mRewoundList.destroy();
         mTabs.clear();
         mObservers.clear();
-
+        mRecentlyClosedBridge.destroy();
         super.destroy();
     }
 
     @Override
     public void addObserver(TabModelObserver observer) {
         mObservers.addObserver(observer);
     }
 
     @Override
     public void removeObserver(TabModelObserver observer) {
@@ skipping 601 matching lines @@
 
     @Override
     protected TabCreator getTabCreator(boolean incognito) {
         return incognito ? mIncognitoTabCreator : mRegularTabCreator;
     }
 
     @Override
     protected boolean createTabWithWebContents(Tab parent, boolean incognito,
             WebContents webContents, int parentId) {
         return getTabCreator(incognito).createTabWithWebContents(parent, webContents, parentId,
-                TabLaunchType.FROM_LONGPRESS_BACKGROUND);
+                TabLaunchType.FROM_LONGPRESS_FOREGROUND);

[Theresa, 2016/06/29 23:53:29]

I suspect that changing this affects other places that were originally relying
on this method to open things in the background.

[xingliu, 2016/06/30 05:43:55]

Used to investigate this a little bit, this change make the restore tab to the
foreground when using tab restore service code in c++. In java, it seems we have
other class manage the tab ordering(and I guess foreground and ordering are
totally manged in java because they are android UI). And this enum seems totally
serve for other purpose.

I agree to put a TODO here to figure out if this break anything.

However, the worst case scenario I can think of is, this stuff might make
restored pages running javascripts in the background.

[Theresa, 2016/06/30 20:50:24]

If you go to "Recent tabs", long press on a recently closed tab or a tab from
another device and select "Open in new tab" previously this opened in the
background but with this patch it opens in the foreground.

For phones in particular, I think we want to retain the open in background
behavior so that this use case doesn't break:
1. Go to recents
2. Open a bunch of things in new tabs in the background
3. Look through newly created tabs.

This method could take a new parameter indicating whether the tab should open in
the foreground or background.

I think we should make sure UX agrees that ctrl+shift+t tabs should restore in
the foreground before adding the plumbing. I can introduce you to rolfe@ this
afternoon or tomorrow if we don't hear back soon :)

     }
 
     @Override
     public int getCount() {
         return mTabs.size();
     }
 
     @Override
     public int index() {
         return mIndex;
     }
 
     @Override
     protected boolean isSessionRestoreInProgress() {
         return mModelDelegate.isSessionRestoreInProgress();
     }
+
+    /**
+     * Open most recent closed tab. first check if android tab model has pending closures.
+     * if not, use native code to fetch data from tab restore service.
+     */
+    @Override
+    public void openRecentClosedTab() {
+        // recover tab from rewind list in java, same as the undo snackbar.

[Theresa, 2016/06/29 23:53:29]

nit: use proper sentence capitalization/punctuation for comments e.g. "First try
to recover the tab from the rewound list."

http://source.android.com/source/code-style.html#use-javadoc-standard-comments

[xingliu, 2016/06/30 05:43:55]

Done.

+        // {@link UndoBarController}.
+        if (mRewoundList.hasPendingClosures()) {
+            Tab tab = mRewoundList.getNextRewindableTab();
+            if (tab == null) return;
+            cancelTabClosure(tab.getId());
+            return;
+        }
+
+        // if no pending closure in java, open it from tab restore service in native code.

[Theresa, 2016/06/29 23:53:29]

nit: "If there are no pending closures in Java, ..."

[xingliu, 2016/06/30 05:43:55]

Done.

+        mRecentlyClosedBridge.openRecentClosedTab();
+    }
 }