Expand autofill profile merge logic.

components/autofill/core/browser/autofill_profile_comparator.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_PROFILE_COMPARATOR_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_PROFILE_COMPARATOR_H_
 
 #include <memory>
 #include <set>
 
 #include "base/strings/string16.h"
 #include "base/strings/string_piece.h"
+#include "components/autofill/core/browser/address.h"
 #include "components/autofill/core/browser/autofill_profile.h"
+#include "components/autofill/core/browser/contact_info.h"
 #include "components/autofill/core/common/autofill_l10n_util.h"
 #include "third_party/icu/source/i18n/unicode/translit.h"
 
 namespace autofill {
 
 // A utility class to assist in the comparison of AutofillProfile data.
 class AutofillProfileComparator {
  public:
   explicit AutofillProfileComparator(const base::StringPiece& app_locale);
   ~AutofillProfileComparator();
@@ skipping 14 matching lines @@
       WhitespaceSpec whitespace_spec = RETAIN_WHITESPACE) const;
 
   // Returns true if |p1| and |p2| are viable merge candidates. This means that
   // their names, addresses, email addreses, company names, and phone numbers
   // are all pairwise equivalent or mergeable.
   //
   // Note that mergeability is non-directional; merging two profiles will likely
   // incorporate data from both profiles.
   bool AreMergeable(const AutofillProfile& p1, const AutofillProfile& p2) const;
 
+  // Populates |name_info| with the result of merging the names in |p1| and
+  // |p2|. Returns true if successful. Expects that |p1| and |p2| have already
+  // been found to be mergeable.

[tmartino, 2016/06/27 17:56:46]

Can you add a brief description to these docs of the logic used to select the
final value? I noticed there are differences between the two (e.g., email
addresses go by use date, whereas names do not) so it would be good to have that
written out.

[Roger McFarlane (Chromium), 2016/06/28 17:26:47]

Done.

+  bool MergeNames(const AutofillProfile& p1,
+                  const AutofillProfile& p2,
+                  NameInfo* name_info) const;
+
+  // Populates |email_info| with the result of merging the email addresses in
+  // |p1| and |p2|. Returns true if successful. Expects that |p1| and |p2| have
+  // already been found to be mergeable.
+  bool MergeEmailAddresses(const AutofillProfile& p1,
+                           const AutofillProfile& p2,
+                           EmailInfo* email_info) const;
+
+  // Populates |company_info| with the result of merging the company names in
+  // |p1| and |p2|. Returns true if successful. Expects that |p1| and |p2| have
+  // already been found to be mergeable.
+  bool MergeCompanyNames(const AutofillProfile& p1,
+                         const AutofillProfile& p2,
+                         CompanyInfo* company_info) const;
+
+  // Populates |phone_number| with the result of merging the phone numbers in
+  // |p1| and |p2|. Returns true if successful. Expects that |p1| and |p2| have
+  // already been found to be mergeable.
+  bool MergePhoneNumbers(const AutofillProfile& p1,
+                         const AutofillProfile& p2,
+                         PhoneNumber* phone_number) const;
+
+  // Populates |address| with the result of merging the addresses in |p1| and
+  // |p2|. Returns true if successful. Expects that |p1| and |p2| have already
+  // been found to be mergeable.
+  bool MergeAddresses(const AutofillProfile& p1,
+                      const AutofillProfile& p2,
+                      Address* address) const;
+
  protected:
+  // The result type returned by CompareTokens.
+  enum CompareTokensResult {
+    DIFFERENT_TOKENS,
+    SAME_TOKENS,
+    S1_CONTAINS_S2,
+    S2_CONTAINS_S1,
+  };
+
   // Returns the set of unique tokens in |s|. Note that the string data backing
   // |s| is expected to have a lifetime which exceeds the call to UniqueTokens.
   static std::set<base::StringPiece16> UniqueTokens(base::StringPiece16 s);
 
-  // Returns true if all of the tokens in |s1| are in |s2| or vice versa.
-  static bool HaveSameTokens(base::StringPiece16 s1, base::StringPiece16 s2);
+  // Compares the unique tokens in s1 and s2.
+  static CompareTokensResult CompareTokens(base::StringPiece16 s1,
+                                           base::StringPiece16 s2);
+
+  // Returns the value of |t| from |p1| or |p2| depending on which is non-empty.
+  // This method expects that the value is either the same in |p1| or |p2| or

[tmartino, 2016/06/27 17:56:46]

nit: Should this read "either the same in |p1| AND |p2|" instead of "or"?

[Roger McFarlane (Chromium), 2016/06/28 17:26:47]

Done.

+  // empty in one of them.
+  base::string16 GetNonEmptyOf(const AutofillProfile& p1,
+                               const AutofillProfile& p2,
+                               AutofillType t) const;
 
   // Generate the set of full/initial variants for |name_part|, where
   // |name_part| is the user's first or middle name. For example, given "jean
   // francois" (the normalized for comparison form of "Jean-François") this
   // function returns the set:
   //
   //   { "", "f", "francois,
   //     "j", "j f", "j francois",
   //     "jean", "jean f", "jean francois", "jf" }
   //
@@ skipping 68 matching lines @@
   l10n::CaseInsensitiveCompare case_insensitive_compare_;
   std::unique_ptr<icu::Transliterator> transliterator_;
   const std::string app_locale_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillProfileComparator);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_PROFILE_COMPARATOR_H_