Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2088433002: Remove calls to MessageLoop::current() in jingle. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in jingle. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 R=sergeyu@chromium.org Committed: https://crrev.com/038016b7d0e4e1356bcc5a01ba9a78ed3f8b9151 Cr-Commit-Position: refs/heads/master@{#401032}

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M jingle/glue/proxy_resolving_client_socket.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download
M jingle/notifier/base/xmpp_connection.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sergey Ulanov
https://codereview.chromium.org/2088433002/diff/1/jingle/glue/proxy_resolving_client_socket.cc File jingle/glue/proxy_resolving_client_socket.cc (right): https://codereview.chromium.org/2088433002/diff/1/jingle/glue/proxy_resolving_client_socket.cc#newcode153 jingle/glue/proxy_resolving_client_socket.cc:153: CHECK(base::ThreadTaskRunnerHandle::IsSet()); I don't think you need this CHECK(). There ...
4 years, 6 months ago (2016-06-20 22:53:25 UTC) #1
fdoray
PTAnL https://codereview.chromium.org/2088433002/diff/1/jingle/glue/proxy_resolving_client_socket.cc File jingle/glue/proxy_resolving_client_socket.cc (right): https://codereview.chromium.org/2088433002/diff/1/jingle/glue/proxy_resolving_client_socket.cc#newcode153 jingle/glue/proxy_resolving_client_socket.cc:153: CHECK(base::ThreadTaskRunnerHandle::IsSet()); On 2016/06/20 22:53:25, Sergey Ulanov wrote: > ...
4 years, 6 months ago (2016-06-21 13:01:51 UTC) #2
Sergey Ulanov
LGTM. Thanks for the cleanup!
4 years, 6 months ago (2016-06-21 16:49:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088433002/20001
4 years, 6 months ago (2016-06-21 16:55:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 17:41:10 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 17:50:00 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/038016b7d0e4e1356bcc5a01ba9a78ed3f8b9151
Cr-Commit-Position: refs/heads/master@{#401032}

Powered by Google App Engine
This is Rietveld 408576698