Add the beginning of a public Service Worker API.

content/browser/service_worker/service_worker_context_wrapper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_context_wrapper.h"
 
 #include "base/files/file_path.h"
 #include "content/browser/service_worker/service_worker_context_core.h"
 #include "content/public/browser/browser_thread.h"
 #include "webkit/browser/quota/quota_manager_proxy.h"
@@ skipping 31 matching lines @@
     return;
   }
   context_core_.reset();
 }
 
 ServiceWorkerContextCore* ServiceWorkerContextWrapper::context() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   return context_core_.get();
 }
 
+void ServiceWorkerContextWrapper::RegisterServiceWorker(
+    const GURL& pattern,
+    const GURL& script_url,
+    int source_process_id,
+    const RegistrationCallback& continuation) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  BrowserThread::PostTask(
+      BrowserThread::IO,
+      FROM_HERE,
+      base::Bind(&ServiceWorkerContextWrapper::RegisterServiceWorkerOnIO,

[kinuko, 2014/03/26 05:01:34]

Instead of having yet another indirection method we can also do:

 if (!BrowserThread::CurrentlyOn(IO)) {
   BrowserThread::PostTask(IO, ..., Bind(&RegisterServiceWorker));
   return;
 }
 context()->RegisterServiceWorker(...);

We do this in ServiceWorkerContextWrapper::Shutdown().

Also FinishRegistrationOnIO and FinishUnregistrationOnIO could be a local static
method, then this class only needs 1 method impl for one public API instead of
3. I'm fine with the current rigid style but compactness has some win too (esp.
when we're in a wrapper class which is supposed to be thin)... wdyt?

[Jeffrey Yasskin, 2014/03/26 19:58:52]

Sure, done.
Sounds good. I think I liked making them member functions in order to keep the
order of definitions in the same order as the control flow, but with only one
helper function that's less compelling, and they could have been static in the
first place.

+                 this,
+                 pattern,
+                 script_url,
+                 source_process_id,
+                 continuation));
+}
+
+void ServiceWorkerContextWrapper::RegisterServiceWorkerOnIO(

[kinuko, 2014/03/26 05:01:34]

I know this ordering has some benfits, but can we match method order in .cc and
in .h? (Per our style guide)

[Jeffrey Yasskin, 2014/03/26 19:58:52]

Obsolete now.

+    const GURL& pattern,
+    const GURL& script_url,
+    int source_process_id,
+    const RegistrationCallback& continuation) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  context()->RegisterServiceWorker(
+      pattern,
+      script_url,
+      source_process_id,
+      base::Bind(&ServiceWorkerContextWrapper::FinishRegistrationOnIO,
+                 this,
+                 continuation));
+}
+
+void ServiceWorkerContextWrapper::FinishRegistrationOnIO(
+    const RegistrationCallback& continuation,
+    ServiceWorkerStatusCode status,
+    int64 registration_id) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  BrowserThread::PostTask(
+      BrowserThread::UI, FROM_HERE, base::Bind(continuation, status));
+}
+
+void ServiceWorkerContextWrapper::UnregisterServiceWorker(
+    const GURL& pattern,
+    int source_process_id,
+    const UnregistrationCallback& continuation) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  BrowserThread::PostTask(
+      BrowserThread::IO,
+      FROM_HERE,
+      base::Bind(&ServiceWorkerContextWrapper::UnregisterServiceWorkerOnIO,
+                 this,
+                 pattern,
+                 source_process_id,
+                 continuation));
+}
+
+void ServiceWorkerContextWrapper::UnregisterServiceWorkerOnIO(
+    const GURL& pattern,
+    int source_process_id,
+    const UnregistrationCallback& continuation) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  context()->UnregisterServiceWorker(
+      pattern,
+      source_process_id,
+      base::Bind(&ServiceWorkerContextWrapper::FinishUnregistrationOnIO,
+                 this,
+                 continuation));
+}
+void ServiceWorkerContextWrapper::FinishUnregistrationOnIO(
+    const RegistrationCallback& continuation,
+    ServiceWorkerStatusCode status) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  BrowserThread::PostTask(
+      BrowserThread::UI, FROM_HERE, base::Bind(continuation, status));
+}
+
 }  // namespace content