Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 208843002: Revert of Fix GPU displacement with expanding crop rects. (Closed)

Created:
6 years, 9 months ago by epoger
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of Fix GPU displacement with expanding crop rects. (https://codereview.chromium.org/195973007/) Reason for revert: Speculative revert (for trybot consumption) per https://code.google.com/p/skia/issues/detail?id=2313#c13 Original issue's description: > Fix GPU displacement with expanding crop rects. > > Fix GPU displacement with expanding crop rects, and re-enable the > imagefilterscropexpand GM. There were two bugs: the result texture was > being created at input color bitmap size, not the cropped bounds size, > and the matrix in GrContext was not being set to identity before draw. > > R=junov@chromium.org > > Committed: https://code.google.com/p/skia/source/detail?r=13844 TBR=junov@chromium.org,senorblanco@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M gyp/gmslides.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
epoger
Created Revert of Fix GPU displacement with expanding crop rects.
6 years, 9 months ago (2014-03-21 19:02:30 UTC) #1
epoger
6 years, 9 months ago (2014-03-21 19:02:33 UTC) #2
The CQ bit was unchecked by epoger@google.com

Powered by Google App Engine
This is Rietveld 408576698