| OLD | NEW |
| 1 # Copyright 2012 the V8 project authors. All rights reserved. | 1 # Copyright 2012 the V8 project authors. All rights reserved. |
| 2 # Redistribution and use in source and binary forms, with or without | 2 # Redistribution and use in source and binary forms, with or without |
| 3 # modification, are permitted provided that the following conditions are | 3 # modification, are permitted provided that the following conditions are |
| 4 # met: | 4 # met: |
| 5 # | 5 # |
| 6 # * Redistributions of source code must retain the above copyright | 6 # * Redistributions of source code must retain the above copyright |
| 7 # notice, this list of conditions and the following disclaimer. | 7 # notice, this list of conditions and the following disclaimer. |
| 8 # * Redistributions in binary form must reproduce the above | 8 # * Redistributions in binary form must reproduce the above |
| 9 # copyright notice, this list of conditions and the following | 9 # copyright notice, this list of conditions and the following |
| 10 # disclaimer in the documentation and/or other materials provided | 10 # disclaimer in the documentation and/or other materials provided |
| (...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 216 return [] | 216 return [] |
| 217 | 217 |
| 218 | 218 |
| 219 def _CommonChecks(input_api, output_api): | 219 def _CommonChecks(input_api, output_api): |
| 220 """Checks common to both upload and commit.""" | 220 """Checks common to both upload and commit.""" |
| 221 results = [] | 221 results = [] |
| 222 results.extend(input_api.canned_checks.CheckOwners( | 222 results.extend(input_api.canned_checks.CheckOwners( |
| 223 input_api, output_api, source_file_filter=None)) | 223 input_api, output_api, source_file_filter=None)) |
| 224 results.extend(input_api.canned_checks.CheckPatchFormatted( | 224 results.extend(input_api.canned_checks.CheckPatchFormatted( |
| 225 input_api, output_api)) | 225 input_api, output_api)) |
| 226 results.extend(input_api.canned_checks.CheckGenderNeutral( |
| 227 input_api, output_api)) |
| 226 results.extend(_V8PresubmitChecks(input_api, output_api)) | 228 results.extend(_V8PresubmitChecks(input_api, output_api)) |
| 227 results.extend(_CheckUnwantedDependencies(input_api, output_api)) | 229 results.extend(_CheckUnwantedDependencies(input_api, output_api)) |
| 228 results.extend( | 230 results.extend( |
| 229 _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api)) | 231 _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api)) |
| 230 results.extend( | 232 results.extend( |
| 231 _CheckNoInlineHeaderIncludesInNormalHeaders(input_api, output_api)) | 233 _CheckNoInlineHeaderIncludesInNormalHeaders(input_api, output_api)) |
| 232 return results | 234 return results |
| 233 | 235 |
| 234 | 236 |
| 235 def _SkipTreeCheck(input_api, output_api): | 237 def _SkipTreeCheck(input_api, output_api): |
| (...skipping 15 matching lines...) Expand all Loading... |
| 251 def CheckChangeOnCommit(input_api, output_api): | 253 def CheckChangeOnCommit(input_api, output_api): |
| 252 results = [] | 254 results = [] |
| 253 results.extend(_CommonChecks(input_api, output_api)) | 255 results.extend(_CommonChecks(input_api, output_api)) |
| 254 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 256 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 255 input_api, output_api)) | 257 input_api, output_api)) |
| 256 if not _SkipTreeCheck(input_api, output_api): | 258 if not _SkipTreeCheck(input_api, output_api): |
| 257 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 259 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| 258 input_api, output_api, | 260 input_api, output_api, |
| 259 json_url='http://v8-status.appspot.com/current?format=json')) | 261 json_url='http://v8-status.appspot.com/current?format=json')) |
| 260 return results | 262 return results |
| OLD | NEW |