third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp - Issue 2088383002: Partly revert Invalidate as DisplayItemClient when PaintLayer is setNeedsRepaint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 2088383002: Partly revert Invalidate as DisplayItemClient when PaintLayer is setNeedsRepaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

index d22dc42c3e8ef23e044adc7d9e672b768fb32489..ce2ed70d1b953993744f7ce446038ededa2c43aa 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

@@ -219,7 +219,7 @@ void PaintController::copyCachedSubsequence(const DisplayItemList& currentList,

DCHECK(currentIt != m_currentPaintArtifact.getDisplayItemList().end());

DCHECK(currentIt->hasValidClient());

#if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS

- CHECK(clientCacheIsValid(currentIt->client()) || !currentIt->isCacheable());

+ CHECK(currentIt->client().isAlive());

#endif

updatedList.appendByMoving(*currentIt, currentList.visualRect(currentIt - m_currentPaintArtifact.getDisplayItemList().begin()), gpuAnalyzer);

++currentIt;

« no previous file with comments | « no previous file | no next file » | no next file with comments »