Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2088343003: Revert of Flip remaining chromium.webrtc* builders to GN. (Closed)

Created:
4 years, 6 months ago by phoglund
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_skia
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip remaining chromium.webrtc* builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2085873005/ ) Reason for revert: Speculative revert: causes H264 regression (?): https://bugs.chromium.org/p/chromium/issues/detail?id=622632 BUG=622632 Original issue's description: > Flip remaining chromium.webrtc* builders to GN. > > There are very few GYP builders remaining on the chromium waterfalls; > all of the main builders have been flipped to GN, so WebRTC should be > testing that config now. > > R=kjellander@chromium.org > BUG=605318, 618468 > > Committed: https://crrev.com/cb929f6769c9a834e5941a2412ec2883b3b162fe > Cr-Commit-Position: refs/heads/master@{#401327} TBR=kjellander@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605318, 618468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
phoglund
Created Revert of Flip remaining chromium.webrtc* builders to GN.
4 years, 6 months ago (2016-06-23 09:54:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088343003/1
4 years, 6 months ago (2016-06-23 09:54:38 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-23 09:54:43 UTC) #5
phoglund_chromium
heh, wrong users. lgtm
4 years, 6 months ago (2016-06-23 09:57:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088343003/1
4 years, 6 months ago (2016-06-23 09:57:52 UTC) #9
commit-bot: I haz the power
The author phoglund@webrtc.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
4 years, 6 months ago (2016-06-23 09:57:55 UTC) #11
phoglund_chromium
mnyeh, ok, I'll use the right user: https://codereview.chromium.org/2095473004/
4 years, 6 months ago (2016-06-23 10:01:06 UTC) #13
phoglund_chromium
4 years, 6 months ago (2016-06-23 11:56:52 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2081393005/ by phoglund@chromium.org.

The reason for reverting is: This revert broke the WebRTC win build (?).

Powered by Google App Engine
This is Rietveld 408576698