improve unicode support

recipe_engine/step_runner.py

Index: recipe_engine/step_runner.py
diff --git a/recipe_engine/step_runner.py b/recipe_engine/step_runner.py
index 97c1686d250375eaced072260b03f4cd454179ed..a36f7e1e75c4a60d1ed6e8afe82ea7bcdcf0de28 100644
--- a/recipe_engine/step_runner.py
+++ b/recipe_engine/step_runner.py
@@ -2,7 +2,7 @@
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
-import cStringIO
+import StringIO

[Paweł Hajdan Jr., 2016/06/23 14:51:54]

Why are we changing from cStringIO to StringIO? The former was supposed to be
faster.

[M-A Ruel, 2016/06/23 15:06:45]

I've never seen it being faster in practice, when I did perf testing.

[martiniss, 2016/06/23 17:32:14]

cStringIO doesn't work with unicode, sadly. :/

 import collections
 import contextlib
 import datetime
@@ -45,7 +45,7 @@ if sys.platform == "win32":
 class _streamingLinebuf(object):
   def __init__(self):
     self.buffedlines = []
-    self.extra = cStringIO.StringIO()
+    self.extra = StringIO.StringIO()
 
   def ingest(self, data):
     lines = data.splitlines()
@@ -56,7 +56,7 @@ class _streamingLinebuf(object):
       self.extra.write(lines[0])
       if len(lines) > 1 or endedOnLinebreak:
         lines[0] = self.extra.getvalue()
-        self.extra = cStringIO.StringIO()
+        self.extra = StringIO.StringIO()
       else:
         return
 
@@ -419,7 +419,7 @@ class SimulationStepRunner(StepRunner):
     step_test = self._test_data.pop_step_test_data(
         step_dict['name'], test_data_fn)
     step_dict, placeholders = render_step(step_dict, step_test)
-    outstream = cStringIO.StringIO()
+    outstream = StringIO.StringIO()
 
     # Layer the simulation step on top of the given stream engine.
     step_stream = stream.ProductStreamEngine.StepStream(