Make IdentifiersFactory thread-safe

Make IdentifiersFactory thread-safe

IdentifiersFactory can be used not only from main thread but also from
ScriptStreamer thread, so it should not hold process ID prefix as
thread-unsafe WTF::String. This fixes crash when devtools.timeline
tracing is enabled.

This patch also makes s_lastUsedIdentifier increment atomically.

BUG=621473, 612282
Committed: https://crrev.com/0751df2ff806e1ed303c2f652a090057d6768ba1
Cr-Commit-Position: refs/heads/master@{#401778}

[Kunihiko Sakamoto, 2016-06-23 08:35:04]

Description was changed from

==========
WIP
==========

to

==========
Fix crash when devtools.timeline tracing is enabled

IdentifiersFactory can be used not only from main thread but also from
ScriptStreamer thread, so it should not hold process ID prefix as
thread-unsafe WTF::String.

BUG=621473,612282
==========

[Kunihiko Sakamoto, 2016-06-23 10:17:00]

ksakamoto@chromium.org changed reviewers:
+ caseq@chromium.org, dgozman@chromium.org

[Kunihiko Sakamoto, 2016-06-23 10:17:01]

PTAL

[alph, 2016-06-23 17:15:40]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-06-23 17:15:40]

caseq is on vacation. lgtm

[dgozman, 2016-06-23 17:20:52]

https://codereview.chromium.org/2088333003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp (right):

https://codereview.chromium.org/2088333003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp:40: static long
s_lastUsedIdentifier = 0;
Don't you have to make this thread static or use atomics?

[Kunihiko Sakamoto, 2016-06-24 00:00:18]

https://codereview.chromium.org/2088333003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp (right):

https://codereview.chromium.org/2088333003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp:40: static long
s_lastUsedIdentifier = 0;
On 2016/06/23 17:20:51, dgozman wrote:
> Don't you have to make this thread static or use atomics?

Yeah, probably. Done.

[Kunihiko Sakamoto, 2016-06-24 00:45:31]

Description was changed from

==========
Fix crash when devtools.timeline tracing is enabled

IdentifiersFactory can be used not only from main thread but also from
ScriptStreamer thread, so it should not hold process ID prefix as
thread-unsafe WTF::String.

BUG=621473,612282
==========

to

==========
Make IdentifiersFactory thread-safe

IdentifiersFactory can be used not only from main thread but also from
ScriptStreamer thread, so it should not hold process ID prefix as
thread-unsafe WTF::String. This fixes crash when devtools.timeline
tracing is enabled.

This patch also makes s_lastUsedIdentifier increment atomically.

BUG=621473, 612282
==========

[kouhei (in TOK), 2016-06-24 00:49:07]

kouhei@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2016-06-24 00:49:08]

lgtm

[Kunihiko Sakamoto, 2016-06-24 01:03:37]

The CQ bit was checked by ksakamoto@chromium.org

[Kunihiko Sakamoto, 2016-06-24 01:03:38]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2088333003/#ps40001
(title: "long -> int")

[commit-bot: I haz the power, 2016-06-24 01:04:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2088333003/40001

[commit-bot: I haz the power, 2016-06-24 01:48:31]

Description was changed from

==========
Make IdentifiersFactory thread-safe

IdentifiersFactory can be used not only from main thread but also from
ScriptStreamer thread, so it should not hold process ID prefix as
thread-unsafe WTF::String. This fixes crash when devtools.timeline
tracing is enabled.

This patch also makes s_lastUsedIdentifier increment atomically.

BUG=621473, 612282
==========

to

==========
Make IdentifiersFactory thread-safe

IdentifiersFactory can be used not only from main thread but also from
ScriptStreamer thread, so it should not hold process ID prefix as
thread-unsafe WTF::String. This fixes crash when devtools.timeline
tracing is enabled.

This patch also makes s_lastUsedIdentifier increment atomically.

BUG=621473, 612282
==========

[commit-bot: I haz the power, 2016-06-24 01:48:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-24 01:50:25]

Description was changed from

==========
Make IdentifiersFactory thread-safe

IdentifiersFactory can be used not only from main thread but also from
ScriptStreamer thread, so it should not hold process ID prefix as
thread-unsafe WTF::String. This fixes crash when devtools.timeline
tracing is enabled.

This patch also makes s_lastUsedIdentifier increment atomically.

BUG=621473, 612282
==========

to

==========
Make IdentifiersFactory thread-safe

IdentifiersFactory can be used not only from main thread but also from
ScriptStreamer thread, so it should not hold process ID prefix as
thread-unsafe WTF::String. This fixes crash when devtools.timeline
tracing is enabled.

This patch also makes s_lastUsedIdentifier increment atomically.

BUG=621473, 612282

Committed: https://crrev.com/0751df2ff806e1ed303c2f652a090057d6768ba1
Cr-Commit-Position: refs/heads/master@{#401778}
==========

[commit-bot: I haz the power, 2016-06-24 01:50:26]

Patchset 3 (id:??) landed as
https://crrev.com/0751df2ff806e1ed303c2f652a090057d6768ba1
Cr-Commit-Position: refs/heads/master@{#401778}