Show time in hours, minutes and seconds in chrome://memory-internals

ui/webui/resources/js/util.js

Index: ui/webui/resources/js/util.js
diff --git a/ui/webui/resources/js/util.js b/ui/webui/resources/js/util.js
index 56e2d2d283c0334f0dd4c6dd5f31bf0957deb38d..7c5ae929700f6a02cb58fabf65e4de35e7faa198 100644
--- a/ui/webui/resources/js/util.js
+++ b/ui/webui/resources/js/util.js
@@ -424,3 +424,21 @@ function elide(original, maxLength) {
     return original;
   return original.substring(0, maxLength - 1) + '\u2026';
 }
+
+
+/**
+ * Produces a readable HH hours MM min. SS sec. string representing

[Bernhard Bauer, 2014/03/25 16:36:10]

Nit: This sentence reads a big bumpy. How about "[...] a readable string in the
format '<HH> hours <MM> min. <SS> sec.' [...]"?

+ * the amount of time provided as the number of seconds.
+ * @param {number} totalSeconds The total amount of seconds.
+ * @return {string} The formatted HH hours/hours MM min. SS sec. string
+ */
+function secondsToHMS(totalSeconds)
+{

[arv (Not doing code reviews), 2014/03/25 16:34:40]

{ on previous line

[Bernhard Bauer, 2014/03/25 16:36:10]

Opening braces goes on the previous line.

+  totalSeconds = Number(totalSeconds);
+  var hour = Math.floor(totalSeconds / 3600);
+  var min = Math.floor(totalSeconds % 3600 / 60);
+  var sec = Math.floor(totalSeconds % 60);
+  return ((hour > 0 ? (hour + (hour > 1 ? ' hours ':' hour ')) : '') +

[arv (Not doing code reviews), 2014/03/25 16:34:40]

Maybe use Intl.DateTimeFormat instead?

[arv (Not doing code reviews), 2014/03/25 16:34:40]

too many parentheses (the return expression is wrapped in one which is not
needed)

return (expr);

=>

return expr;

[Bernhard Bauer, 2014/03/25 16:36:10]

This is of course an i18n nightmare. But the page where it is included is also
not i18nized, so I guess functionality-wise it's okay. I'm just a bit worried
about adding this method to a general utility library (and Web UI in general is
definitely i18n-aware). Maybe it would actually be better to move this back to
memory_internals.js?

[arv (Not doing code reviews), 2014/03/25 16:38:15]

I didn't even notice that this was in util.js

Please move to another file. util.js is used in a lot of places.

+          (min > 0 ? (min + ' min. '): '' ) +
+          (sec + ' sec. '));
+}