Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2088253002: Revert of GN (Closed)

Created:
4 years, 6 months ago by mtklein
Modified:
4 years, 6 months ago
Reviewers:
bsalomon, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of GN (patchset #12 id:220001 of https://codereview.chromium.org/2087593002/ ) Reason for revert: gclient not happy on some bots Original issue's description: > GN > > What we've got here is a little GN MVP. It's lacking any knobs and doesn't yet build anything but libskia, zlib, libpng, and libjpeg-turbo. I've been hopping back and forth between Linux at work and Mac at home. These seem to be at least partially working, enough to build and run cmake/example.cpp. > > The xcode backend seems to work. From here, we can start exploring how to handle other backends (cmake,Android make, Google3). There are a couple things I want to try: > - add another backend like vs or xcode to GN directly > - intercept via a custom toolchain > - reverse from ninja -t commands > That last option seems kind of fun. > > This tries to piggyback on Chrome's GN setup as much as possible. Chrome's got quite a lot figured out, and we're basically required to do this if we want to have a single GN build system shareable by Chrome, our bots, and other clients. > > This pulls in some new DEPS: > - build: Chrome's GN configuration, and much more > - buildtools: hashes for gn binary, pulled via hooks > - tools/clang: hashes for Chrome's clang, pulled via hooks into third_party/llvm-build > It additionally symlinks tools/gyp to third_party/externals/gyp. GN pulls some stuff from tools/gyp on Mac. > > Have not yet tried building for Windows, Android, or iOS. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087593002 > > Committed: https://skia.googlesource.com/skia/+/1d8de594f126b9a80bd8f8fa2005e90faf3b5b17 TBR=bsalomon@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/3917cf4ef76dabecd340f1e4cd7999802809e5ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -464 lines) Patch
M .gitignore View 1 chunk +0 lines, -5 lines 0 comments Download
D .gn View 1 chunk +0 lines, -1 line 0 comments Download
D BUILD.gn View 1 chunk +0 lines, -265 lines 0 comments Download
M DEPS View 2 chunks +0 lines, -55 lines 0 comments Download
D build_overrides/build.gni View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/BUILD.gn View 1 chunk +0 lines, -134 lines 0 comments Download
D tools/gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of GN
4 years, 6 months ago (2016-06-22 17:06:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088253002/1
4 years, 6 months ago (2016-06-22 17:07:01 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 17:07:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3917cf4ef76dabecd340f1e4cd7999802809e5ca

Powered by Google App Engine
This is Rietveld 408576698