Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2088233003: Serialize erroneous element and more (Closed)

Created:
4 years, 6 months ago by Johnni Winther
Modified:
4 years, 6 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Serialize erroneous element and more - Adds support for serialization/deserialization of ErroneousElement. - Imports dart:core for serialized libraries. - Fixes and tests reserialization for ResolvedAst.sourceUri R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/1e27180a6a3935088a4ba9b13ec3e1608faaab67

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -46 lines) Patch
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 5 chunks +40 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/helper.dart View 2 chunks +9 lines, -3 lines 0 comments Download
A tests/compiler/dart2js/serialization/reserialization_test.dart View 1 1 chunk +73 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/resolved_ast_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 6 months ago (2016-06-23 13:07:59 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2088233003/diff/1/tests/compiler/dart2js/serialization/reserialization_test.dart File tests/compiler/dart2js/serialization/reserialization_test.dart (right): https://codereview.chromium.org/2088233003/diff/1/tests/compiler/dart2js/serialization/reserialization_test.dart#newcode23 tests/compiler/dart2js/serialization/reserialization_test.dart:23: bool prettyPrint = false; prettyPrint is not used ...
4 years, 6 months ago (2016-06-23 23:13:25 UTC) #3
Johnni Winther
https://codereview.chromium.org/2088233003/diff/1/tests/compiler/dart2js/serialization/test_helper.dart File tests/compiler/dart2js/serialization/test_helper.dart (right): https://codereview.chromium.org/2088233003/diff/1/tests/compiler/dart2js/serialization/test_helper.dart#newcode566 tests/compiler/dart2js/serialization/test_helper.dart:566: compiler1.resolution.hasResolvedAst(member1); On 2016/06/23 23:13:25, Harry Terkelsen wrote: > is ...
4 years, 6 months ago (2016-06-24 08:26:54 UTC) #4
Johnni Winther
4 years, 6 months ago (2016-06-24 08:38:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1e27180a6a3935088a4ba9b13ec3e1608faaab67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698