[heap] Modernize all *Page iterators to be proper C++ iterators

[heap] Modernize all *Page iterators to be proper C++ iterators

As part of the page type unification also unify page iterators. Iterating
over a space works the same for all spaces now (new, old, lo).

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

For iteration of a range of new space pages use NewSpacePageRange which
also verifies that the range is actually a proper new space page range.

BUG=chromium:581412
LOG=N

Committed: https://crrev.com/4244b989ca7ec6a0889509577af3e7931b4dd6ab
Cr-Commit-Position: refs/heads/master@{#37210}

[Michael Lippautz, 2016-06-22 15:36:25]

Patchset #1 (id:1) has been deleted

[Michael Lippautz, 2016-06-23 06:16:47]

Description was changed from

==========
[heap] Revamp PageIterator

BUG=
==========

to

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

for (auto begin = space->begin(); begin != space->end(); ++it) {
}
  or
for (Page* p : *space) {
}

BUG=
==========

[Michael Lippautz, 2016-06-23 06:17:09]

Description was changed from

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

for (auto begin = space->begin(); begin != space->end(); ++it) {
}
  or
for (Page* p : *space) {
}

BUG=
==========

to

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto begin = space->begin(); begin != space->end(); ++it) {}
- for (Page* p : *space) {}

BUG=
==========

[Michael Lippautz, 2016-06-23 06:17:09]

Description was changed from

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

for (auto begin = space->begin(); begin != space->end(); ++it) {
}
  or
for (Page* p : *space) {
}

BUG=
==========

to

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto begin = space->begin(); begin != space->end(); ++it) {}
- for (Page* p : *space) {}

BUG=
==========

[Michael Lippautz, 2016-06-23 06:17:28]

Description was changed from

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto begin = space->begin(); begin != space->end(); ++it) {}
- for (Page* p : *space) {}

BUG=
==========

to

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

BUG=
==========

[Michael Lippautz, 2016-06-23 06:49:09]

Description was changed from

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

BUG=
==========

to

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting deletion:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    // p can be deleted
  }

BUG=
==========

[Michael Lippautz, 2016-06-23 06:49:27]

Description was changed from

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting deletion:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    // p can be deleted
  }

BUG=
==========

to

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    // p can be deleted
  }

BUG=
==========

[Michael Lippautz, 2016-06-23 06:49:41]

Description was changed from

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    // p can be deleted
  }

BUG=
==========

to

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

BUG=
==========

[Michael Lippautz, 2016-06-23 07:42:57]

Description was changed from

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

BUG=
==========

to

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

BUG=
==========

[Michael Lippautz, 2016-06-23 07:50:32]

Description was changed from

==========
[heap] Revamp PageIterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

BUG=
==========

to

==========
[heap] Make (Large)Page a C++ iterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

BUG=
==========

[Michael Lippautz, 2016-06-23 08:00:50]

Description was changed from

==========
[heap] Make (Large)Page a C++ iterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

BUG=
==========

to

==========
[heap] Make (Large)Page a C++ iterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=
==========

[Michael Lippautz, 2016-06-23 08:01:24]

Patchset #1 (id:20001) has been deleted

[Michael Lippautz, 2016-06-23 08:01:52]

Description was changed from

==========
[heap] Make (Large)Page a C++ iterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=
==========

to

==========
[heap] Make (Large)Page a C++ iterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

[Michael Lippautz, 2016-06-23 08:02:18]

Description was changed from

==========
[heap] Make (Large)Page a C++ iterator

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Make all *Page iterators proper C++ iterators

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

[Michael Lippautz, 2016-06-23 08:03:14]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 08:03:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2088223002/80001

[Michael Lippautz, 2016-06-23 08:04:18]

Description was changed from

==========
[heap] Make all *Page iterators proper C++ iterators

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Make all *Page iterators proper C++ iterators

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

[Michael Lippautz, 2016-06-23 08:06:22]

Description was changed from

==========
[heap] Make all *Page iterators proper C++ iterators

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

[Michael Lippautz, 2016-06-23 08:07:02]

Description was changed from

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

Works now like the regular C++ iterator

- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

Iterating over pages of a space follows now the regular
C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

[Michael Lippautz, 2016-06-23 08:07:14]

Description was changed from

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

Iterating over pages of a space follows now the regular
C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

[Michael Lippautz, 2016-06-23 08:07:44]

Description was changed from

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

[Michael Lippautz, 2016-06-23 08:09:54]

Description was changed from

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

On the way:
- NewSpace is already composed of |Page|s, so get rid of the separate iterator.
- Templatize the implementation to also apply for LargeObjectSpace.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

All page iterators are now unified, i.e., iterating over of a space works
the same for all spaces (new/old/lo).

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

BUG=chromium:581412
LOG=N
==========

[Michael Lippautz, 2016-06-23 08:11:03]

Description was changed from

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

All page iterators are now unified, i.e., iterating over of a space works
the same for all spaces (new/old/lo).

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

All page iterators are now unified, i.e., iterating over of a space works
the same for all spaces (new/old/lo).

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

For iteration of a range of new space pages use NewSpacePageRange which
also verifies that the range is actually a proper new space page range.

BUG=chromium:581412
LOG=N
==========

[commit-bot: I haz the power, 2016-06-23 08:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 08:41:26]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-06-23 09:00:39]

Description was changed from

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

All page iterators are now unified, i.e., iterating over of a space works
the same for all spaces (new/old/lo).

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

For iteration of a range of new space pages use NewSpacePageRange which
also verifies that the range is actually a proper new space page range.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

As part of the page type unification also unify page iterators. Iterating 
over a space works the same for all spaces now (new, old, lo).

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

For iteration of a range of new space pages use NewSpacePageRange which
also verifies that the range is actually a proper new space page range.

BUG=chromium:581412
LOG=N
==========

[Michael Lippautz, 2016-06-23 09:09:25]

mlippautz@chromium.org changed reviewers:
+ jochen@chromium.org

[Michael Lippautz, 2016-06-23 09:09:47]

wdyt?

[Michael Lippautz, 2016-06-23 09:09:47]

wdyt?

[jochen (gone - plz use gerrit), 2016-06-23 09:11:20]

yay, lgtm

[Yang, 2016-06-23 09:11:23]

On 2016/06/23 09:09:47, Michael Lippautz wrote:
> wdyt?

src/snapshot lgtm.

[Michael Lippautz, 2016-06-23 09:53:16]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-06-23 09:53:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2088223002/80001

[commit-bot: I haz the power, 2016-06-23 09:55:25]

Description was changed from

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

As part of the page type unification also unify page iterators. Iterating 
over a space works the same for all spaces now (new, old, lo).

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

For iteration of a range of new space pages use NewSpacePageRange which
also verifies that the range is actually a proper new space page range.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

As part of the page type unification also unify page iterators. Iterating 
over a space works the same for all spaces now (new, old, lo).

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

For iteration of a range of new space pages use NewSpacePageRange which
also verifies that the range is actually a proper new space page range.

BUG=chromium:581412
LOG=N
==========

[commit-bot: I haz the power, 2016-06-23 09:55:26]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-06-23 09:57:20]

Description was changed from

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

As part of the page type unification also unify page iterators. Iterating 
over a space works the same for all spaces now (new, old, lo).

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

For iteration of a range of new space pages use NewSpacePageRange which
also verifies that the range is actually a proper new space page range.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Modernize all *Page iterators to be proper C++ iterators

As part of the page type unification also unify page iterators. Iterating
over a space works the same for all spaces now (new, old, lo).

Iterating over pages of a space follows now the regular C++ iterator pattern:
- for (auto it = space->begin(); it != space->end(); ++it) {}
- for (Page* p : *space) {}

GC only: Loop supporting unlinking/freeing of a Page on the fly:
  for (auto it = space->begin(); != space->end();) {
    Page* p = *(it++);
    p->Unlink();
  }

For iteration of a range of new space pages use NewSpacePageRange which
also verifies that the range is actually a proper new space page range.

BUG=chromium:581412
LOG=N

Committed: https://crrev.com/4244b989ca7ec6a0889509577af3e7931b4dd6ab
Cr-Commit-Position: refs/heads/master@{#37210}
==========

[commit-bot: I haz the power, 2016-06-23 09:57:21]

Patchset 3 (id:??) landed as
https://crrev.com/4244b989ca7ec6a0889509577af3e7931b4dd6ab
Cr-Commit-Position: refs/heads/master@{#37210}