third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html - Issue 2088143003: Convert video-muted* and video-no* tests to testharness.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html

Issue 2088143003: Convert video-muted* and video-no* tests to testharness.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/video-no-autoplay.html ('K') | « third_party/WebKit/LayoutTests/media/video-no-autoplay-expected.txt ('k') | third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html

diff --git a/third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html b/third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html

index 2d0fa8cefe65ffc9aa0309622a49e6a8acebe3b2..894bb857edb7e306c2235912807a39645d174fd4 100644

--- a/third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html

+++ b/third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html

@@ -1,25 +1,25 @@

<!DOCTYPE html>

-<html>

-<body>

- <p>Test that no timeupdate event fires during loading.</p>

- <video></video>

- <script src="media-file.js"></script>

- <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

- (Please avoid writing new tests using video-test.js) -->

- <script src="video-test.js"></script>

- <script>

- waitForEvent("loadstart");

- waitForEvent("loadedmetadata");

- waitForEvent("loadeddata");

- waitForEvent("canplay");

- waitForEvent("canplaythrough", function()

- {

- // Let pending async events fire before ending the test.

- window.setTimeout(function() { endTest(); }, 0);

- });

- waitForEventAndFail("timeupdate");

+<title>Test that no timeupdate event fires during loading.</title>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<script src="media-file.js"></script>

+<video></video>

+<script>

+async_test(function(t) {

+ var video = document.querySelector("video");

+ video.onloadstart = t.step_func(function() {});

+ video.onloadedmetadata = t.step_func(function() {});

+ video.onloadeddata = t.step_func(function() {});

+ video.oncanplay = t.step_func(function() {});

- video.src = findMediaFile("video", "content/test");

- </script>

-</body>

-</html>

+ video.oncanplaythrough = t.step_func(function() {

+ // Let pending async events fire before ending the test.

+ setTimeout(function() {

fs 2016/06/22 10:47:18 Nit: Use step_func_done?

Srirama 2016/06/22 11:15:58 Done.

+ t.done();

+ }, 0);

+ });

+ video.ontimeupdate = t.unreached_func();

+ video.src = findMediaFile("video", "content/test");

+});

+</script>