Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2088143003: Convert video-muted* and video-no* tests to testharness.js. (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-muted* and video-no* tests to testharness.js. Cleaning up video-muted* and video-no* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/d2187c341d97e091e0c970d0d4a400e3e2399fd0 Cr-Commit-Position: refs/heads/master@{#401258}

Patch Set 1 : fix #

Total comments: 4

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -86 lines) Patch
M third_party/WebKit/LayoutTests/media/video-muted.html View 1 chunk +20 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-muted-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-no-autoplay.html View 1 1 chunk +17 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-no-autoplay-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html View 1 1 chunk +21 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-22 07:47:32 UTC) #4
fs
lgtm https://codereview.chromium.org/2088143003/diff/20001/third_party/WebKit/LayoutTests/media/video-no-autoplay.html File third_party/WebKit/LayoutTests/media/video-no-autoplay.html (right): https://codereview.chromium.org/2088143003/diff/20001/third_party/WebKit/LayoutTests/media/video-no-autoplay.html#newcode15 third_party/WebKit/LayoutTests/media/video-no-autoplay.html:15: setTimeout(function() { Nit: Use step_func_done? https://codereview.chromium.org/2088143003/diff/20001/third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html File third_party/WebKit/LayoutTests/media/video-no-timeupdate-before-playback.html ...
4 years, 6 months ago (2016-06-22 10:47:18 UTC) #5
Srirama
https://codereview.chromium.org/2088143003/diff/20001/third_party/WebKit/LayoutTests/media/video-no-autoplay.html File third_party/WebKit/LayoutTests/media/video-no-autoplay.html (right): https://codereview.chromium.org/2088143003/diff/20001/third_party/WebKit/LayoutTests/media/video-no-autoplay.html#newcode15 third_party/WebKit/LayoutTests/media/video-no-autoplay.html:15: setTimeout(function() { On 2016/06/22 10:47:18, fs wrote: > Nit: ...
4 years, 6 months ago (2016-06-22 11:15:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088143003/40001
4 years, 6 months ago (2016-06-22 11:17:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-22 12:31:59 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 12:33:32 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2187c341d97e091e0c970d0d4a400e3e2399fd0
Cr-Commit-Position: refs/heads/master@{#401258}

Powered by Google App Engine
This is Rietveld 408576698