Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1722)

Unified Diff: chrome/install_static/install_util.cc

Issue 2088133002: Switch chrome_elf exception handling from breakpad to crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build error Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_constants.cc ('k') | chrome_elf/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/install_static/install_util.cc
diff --git a/chrome/install_static/install_util.cc b/chrome/install_static/install_util.cc
index db7540d0316c0983a1d0d150c723a585dae2961a..99c0b7cd6e5c74631302b9729737ddbd111b67c4 100644
--- a/chrome/install_static/install_util.cc
+++ b/chrome/install_static/install_util.cc
@@ -907,13 +907,6 @@ std::string GetSwitchValueFromCommandLine(const std::string& command_line,
assert(!command_line.empty());
assert(!switch_name.empty());
- // We don't handle command lines with quoted strings. For e.g. something like
- // --ignored=" --type=renderer ", which we used for Google Desktop.
- if (command_line.find('"') != std::string::npos) {
- assert(false);
- return std::string();
- }
-
std::string command_line_copy = command_line;
// Remove leading and trailing spaces.
TrimT<std::string>(&command_line_copy);
« no previous file with comments | « chrome/common/chrome_constants.cc ('k') | chrome_elf/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698