chrome/browser/chrome_browser_main_win.cc - Issue 2088133002: Switch chrome_elf exception handling from breakpad to crashpad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 2088133002: Switch chrome_elf exception handling from breakpad to crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build error Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_browser_main_win.cc

diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc

index 2dcaec9efdc11251577218d88898c1a9d42b0adf..e0b35f8e3267c8a63be5c39557c16dd2c5191dcd 100644

--- a/chrome/browser/chrome_browser_main_win.cc

+++ b/chrome/browser/chrome_browser_main_win.cc

@@ -85,8 +85,9 @@ void InitializeWindowProcExceptions() {

base::win::WinProcExceptionFilter exception_filter =

reinterpret_cast<base::win::WinProcExceptionFilter>(

::GetProcAddress(::GetModuleHandle(

- chrome::kBrowserProcessExecutableName),

+ chrome::kChromeElfDllName),

"CrashForException"));

+ CHECK(exception_filter);

exception_filter = base::win::SetWinProcExceptionFilter(exception_filter);

DCHECK(!exception_filter);

}

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc » ('j') | no next file with comments »