Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5041)

Unified Diff: chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc

Issue 2088133002: Switch chrome_elf exception handling from breakpad to crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Register crash keys only once in the process. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc
diff --git a/chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc b/chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc
index af1bbec975d5a243f93351425f581263bc543e9f..7348c14e405456bc39d5eaaf59db09f85938d1bd 100644
--- a/chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc
+++ b/chrome/browser/crash_upload_list/crash_upload_list_crashpad.cc
@@ -9,7 +9,6 @@
#include "base/threading/sequenced_worker_pool.h"
#include "base/time/time.h"
#include "build/build_config.h"
-#include "chrome/common/chrome_constants.h"
#include "components/crash/content/app/crashpad.h"
namespace {
@@ -22,9 +21,11 @@ typedef void (*GetCrashReportsPointer)(
void GetReportsThunk(
std::vector<crash_reporter::Report>* reports) {
static GetCrashReportsPointer get_crash_reports = []() {
- HMODULE exe_module = GetModuleHandle(chrome::kBrowserProcessExecutableName);
+ // The crash reporting is handled by chrome_elf.dll which loads early in
+ // the chrome process.
+ HMODULE elf_module = GetModuleHandle(L"chrome_elf.dll");
return reinterpret_cast<GetCrashReportsPointer>(
- exe_module ? GetProcAddress(exe_module, "GetCrashReportsImpl")
+ elf_module ? GetProcAddress(elf_module, "GetCrashReportsImpl")
: nullptr);
}();

Powered by Google App Engine
This is Rietveld 408576698