Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.h

Issue 2088133002: Switch chrome_elf exception handling from breakpad to crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Register crash keys only once in the process. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_crash_reporter_client_win.h
diff --git a/chrome/app/chrome_crash_reporter_client_win.h b/chrome/app/chrome_crash_reporter_client_win.h
index 29109aa3537025860b26ae183ee21fab489dbd78..7f33f52b552cfa04a02f9509a54049852f115272 100644
--- a/chrome/app/chrome_crash_reporter_client_win.h
+++ b/chrome/app/chrome_crash_reporter_client_win.h
@@ -20,6 +20,11 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
ChromeCrashReporterClient();
~ChromeCrashReporterClient() override;
+ // Registers crash keys for debugging purposes. Called from chrome_elf.
+ // TODO(ananta)
+ // Remove this when the change to not require crash key registration lands.
+ static void RegisterCrashKeysForDebugging();
+
// crash_reporter::CrashReporterClient implementation.
bool GetAlternativeCrashDumpLocation(base::string16* crash_dir) override;
void GetProductNameAndVersion(const base::string16& exe_path,
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | chrome/app/chrome_crash_reporter_client_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698