Switch chrome_elf exception handling from breakpad to crashpad.

chrome_elf/chrome_elf_main.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_elf/chrome_elf_main.h"
 
 #include <windows.h>
 
+#include "base/lazy_instance.h"
+#include "chrome/app/chrome_crash_reporter_client_win.h"
 #include "chrome/install_static/install_util.h"
 #include "chrome_elf/blacklist/blacklist.h"
-#include "chrome_elf/breakpad.h"
+#include "chrome_elf/crashpad_helper.h"
+#include "components/crash/content/app/crashpad.h"
 
+namespace {
+base::LazyInstance<std::vector<crash_reporter::Report>>::Leaky

[scottmg, 2016/06/22 19:38:07]

Add \n here, or remove after definition.

[ananta, 2016/06/22 21:08:20]

Done.

+    g_crash_reports = LAZY_INSTANCE_INITIALIZER;
+
+}  // namespace
 
 void SignalChromeElf() {
   blacklist::ResetBeacon();
 }
 
+// This helper is invoked by code in chrome.dll to retrieve the crash reports.
+// See CrashUploadListCrashpad. Note that we do not pass an std::vector here,
+// because we do not want to allocate/free in different modules. The returned
+// pointer is read-only.
+extern "C" __declspec(dllexport) void GetCrashReportsImpl(
+    const crash_reporter::Report** reports,
+  size_t* report_count) {
+  crash_reporter::GetReports(g_crash_reports.Pointer());
+  *reports = g_crash_reports.Pointer()->data();
+  *report_count = g_crash_reports.Pointer()->size();
+}
+
 BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {
   if (reason == DLL_PROCESS_ATTACH) {
     install_static::InitializeProcessType();
-    InitializeCrashReporting();
+    ChromeCrashReporterClient::InitializeCrashReportingForProcess();

[scottmg, 2016/06/22 19:38:07]

It looks like InitializeCrashReportingForProcess redoes the process type check.
Could this go before that?

Otherwise, should it use g_process_type?

[ananta, 2016/06/22 21:08:20]

Switched the order. g_process_type identifies a process as a browser or non
browser based on whether it is sandboxed

 
     __try {
       blacklist::Initialize(false);  // Don't force, abort if beacon is present.
     } __except(GenerateCrashDump(GetExceptionInformation())) {
     }
   }
 
   return TRUE;
 }