Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.h

Issue 2088133002: Switch chrome_elf exception handling from breakpad to crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Register crash keys only once in the process. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_ 5 #ifndef CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
6 #define CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_ 6 #define CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/crash/content/app/crash_reporter_client.h" 9 #include "components/crash/content/app/crash_reporter_client.h"
10 10
11 class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient { 11 class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
12 public: 12 public:
13 #if !defined(NACL_WIN64) 13 #if !defined(NACL_WIN64)
14 // Instantiates a process wide instance of the ChromeCrashReporterClient 14 // Instantiates a process wide instance of the ChromeCrashReporterClient
15 // class and initializes crash reporting for the process. The instance is 15 // class and initializes crash reporting for the process. The instance is
16 // leaked. 16 // leaked.
17 static void InitializeCrashReportingForProcess(); 17 static void InitializeCrashReportingForProcess();
18 #endif 18 #endif
19 19
20 ChromeCrashReporterClient(); 20 ChromeCrashReporterClient();
21 ~ChromeCrashReporterClient() override; 21 ~ChromeCrashReporterClient() override;
22 22
23 // Registers crash keys for debugging purposes. Called from chrome_elf.
24 // TODO(ananta)
25 // Remove this when the change to not require crash key registration lands.
26 static void RegisterCrashKeysForDebugging();
27
23 // crash_reporter::CrashReporterClient implementation. 28 // crash_reporter::CrashReporterClient implementation.
24 bool GetAlternativeCrashDumpLocation(base::string16* crash_dir) override; 29 bool GetAlternativeCrashDumpLocation(base::string16* crash_dir) override;
25 void GetProductNameAndVersion(const base::string16& exe_path, 30 void GetProductNameAndVersion(const base::string16& exe_path,
26 base::string16* product_name, 31 base::string16* product_name,
27 base::string16* version, 32 base::string16* version,
28 base::string16* special_build, 33 base::string16* special_build,
29 base::string16* channel_name) override; 34 base::string16* channel_name) override;
30 bool ShouldShowRestartDialog(base::string16* title, 35 bool ShouldShowRestartDialog(base::string16* title,
31 base::string16* message, 36 base::string16* message,
32 bool* is_rtl_locale) override; 37 bool* is_rtl_locale) override;
(...skipping 13 matching lines...) Expand all
46 51
47 bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override; 52 bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override;
48 53
49 bool EnableBreakpadForProcess(const std::string& process_type) override; 54 bool EnableBreakpadForProcess(const std::string& process_type) override;
50 55
51 private: 56 private:
52 DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient); 57 DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient);
53 }; 58 };
54 59
55 #endif // CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_ 60 #endif // CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | chrome/app/chrome_crash_reporter_client_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698