disable imagefilterscropexpand GM test on Android

disable imagefilterscropexpand GM test on Android

BUG=skia:2313
NOTREECHECKS=True
NOTRY=True

Committed: http://code.google.com/p/skia/source/detail?r=13903

[epoger, 2014-03-22 13:47:13]

See trybot results: by disabling this GM test, at least we get results from all
the others on Test-Android-Nexus10-MaliT604-Arm7-Release.  Then we can work on
re-enabling the test.

So, what say we disable this test for now?

[Stephen White, 2014-03-22 17:48:26]

Pity there isn't a way to disable it only on N10, but LGTM.

[epoger, 2014-03-23 21:12:23]

On 2014/03/22 17:48:26, Stephen White wrote:
> Pity there isn't a way to disable it only on N10, but LGTM.

Good thinking.  Best I can easily do is disable it only on Android, so I did
that.  Sending it through the trybots to make sure it works as expected, and
then I'll commit.

[epoger, 2014-03-23 23:08:00]

On 2014/03/23 21:12:23, epoger wrote:
> On 2014/03/22 17:48:26, Stephen White wrote:
> > Pity there isn't a way to disable it only on N10, but LGTM.
> 
> Good thinking.  Best I can easily do is disable it only on Android, so I did
> that.  Sending it through the trybots to make sure it works as expected, and
> then I'll commit.

As expected...

http://108.170.217.252:10117/builders/Test-Mac10.7-MacMini4.1-GeForce320M-x86...
ran the imagefilterscropexpand,
but
http://108.170.219.162:10117/builders/Test-Android-Nexus10-MaliT604-Arm7-Rele...
did not.

[epoger, 2014-03-23 23:08:11]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-03-23 23:08:13]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/208813004/20001

[commit-bot: I haz the power, 2014-03-23 23:08:20]

Change committed as 13903

[epoger, 2014-03-23 23:12:30]

https://codereview.chromium.org/208813004/diff/20001/gyp/gmslides.gypi
File gyp/gmslides.gypi (right):

https://codereview.chromium.org/208813004/diff/20001/gyp/gmslides.gypi#newcod...
gyp/gmslides.gypi:196: # base class for GMs
Whoops, I left this extra comment line in when copy/pasting a conditions section
from elsewhere.  I only noticed after committing.

[borenet, 2014-03-24 12:40:54]

There are a number of GMs which are disabled on android using "#ifndef
SK_BUILD_FOR_ANDROID".  Not sure which way is better (probably modifying the GYP
file), but we should be consistent.

[epoger, 2014-03-24 14:19:31]

On 2014/03/24 12:40:54, borenet wrote:
> There are a number of GMs which are disabled on android using "#ifndef
> SK_BUILD_FOR_ANDROID".  Not sure which way is better (probably modifying the
GYP
> file), but we should be consistent.

Thanks for that info, Eric, I had forgotten that there were others.  Filed to
myself as https://code.google.com/p/skia/issues/detail?id=2326 ('gather GM tests
which are disabled on Android')