Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 208813002: Merge 255865 "Changing the UsersPerSession UMA metric to count r..." (Closed)

Created:
6 years, 9 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, sadrul, jar (doing other things), stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, asvitkine+watch_chromium.org, kalyank, Ilya Sherman, ben+ash_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Merge 255865 "Changing the UsersPerSession UMA metric to count r..." > Changing the UsersPerSession UMA metric to count relative user amount changes for sessions which can do multi profile > > The old absolute UMA counter was stored upon shutdown. Unfortunately only one in 33 users is shutting down the system properly. As such only a fraction of sessions were accounted for => the values were useless. Furthermore we have decided to only count sessions which could be multi profile sessions. > > The new values are recording state changes like e.g. going from one user to two in a single session. As such you might get a resulting stat counter list of: > > 1: 320 => 320 - 15 - 4 - 1 = 300 single user sessions > 2: 15 => 15 - 4 - 1 = 10 two user sessions > 3: 4 => 4 - 1 = 3 three user sessions > 4: 1 => 1 four user session > > Note that it is not possible for a single user to leave a multi profile session - so the counter will always count up. > > BUG=349055 > TEST=none > > Review URL: https://codereview.chromium.org/180243025 TBR=skuhne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258630

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M ash/multi_profile_uma.h View 1 chunk +2 lines, -1 line 0 comments Download
M ash/multi_profile_uma.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mr4D (OOO till 08-26)
6 years, 9 months ago (2014-03-21 18:30:05 UTC) #1
Mr4D (OOO till 08-26)
6 years, 9 months ago (2014-03-21 18:34:37 UTC) #2
Mr4D (OOO till 08-26)
6 years, 9 months ago (2014-03-21 18:35:11 UTC) #3
Mr4D (OOO till 08-26)
6 years, 9 months ago (2014-03-21 18:35:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r258630 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698