Issue 2088103002: Set -mfloat-abi=hard in pnacl newlib nonsfi toolchain.

Issue 2088103002: Set -mfloat-abi=hard in pnacl newlib nonsfi toolchain. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke

Modified:
4 years, 6 months ago

Reviewers:
Mark Seaborn, Roland McGrath

CC:
chromium-reviews, hidehiko, Petr Hosek

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Set -mfloat-abi=hard in pnacl newlib nonsfi toolchain. R=mcgrathr@chromium.org, mseaborn@chromium.org BUG=621705 Committed: https://crrev.com/f28a9d144d6f6655b1775adef9e1239ae05c682b Cr-Commit-Position: refs/heads/master@{#401189}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/config/compiler/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 10 (4 generated)

Dirk Pranke

I believe the equivalent gyp line is https://cs.chromium.org/chromium/src/native_client/build/untrusted.gypi?rcl=0&l=1038 ?

4 years, 6 months ago (2016-06-22 00:11:59 UTC) #1

Mark Seaborn

LGTM. This is probably necessary but I'm not 100% sure. Are there any ARM trybots ...

4 years, 6 months ago (2016-06-22 00:34:03 UTC) #3

Dirk Pranke

On 2016/06/22 00:34:03, Mark Seaborn wrote: > LGTM. This is probably necessary but I'm not ...

4 years, 6 months ago (2016-06-22 01:42:18 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088103002/1

4 years, 6 months ago (2016-06-22 01:43:13 UTC) #6

commit-bot: I haz the power

4 years, 6 months ago (2016-06-22 03:16:54 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f28a9d144d6f6655b1775adef9e1239ae05c682b
Cr-Commit-Position: refs/heads/master@{#401189}