chrome/browser/resources/md_history/side_bar.js - Issue 2088093004: Add a footer about other forms of history to the MD history page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/side_bar.js

Issue 2088093004: Add a footer about other forms of history to the MD history page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/side_bar.html ('K') | « chrome/browser/resources/md_history/side_bar.html ('k') | chrome/browser/ui/webui/md_history_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/side_bar.js

diff --git a/chrome/browser/resources/md_history/side_bar.js b/chrome/browser/resources/md_history/side_bar.js

index 46291206a7a946a275ea1f235efa49181c46a74d..1abf8bf477dbc5d11f1ce031f7fe0c1534241f86 100644

--- a/chrome/browser/resources/md_history/side_bar.js

+++ b/chrome/browser/resources/md_history/side_bar.js

@@ -10,6 +10,11 @@ Polymer({

type: String,

notify: true

+ showFooter: {

+ type: Boolean,

+ value: false

calamity 2016/07/05 04:03:13 I think you can get away with showFooter: Boolean

msramek 2016/07/06 19:24:10 Done. Probably yes - the call setting this value w

+ }

toggle: function() {